From: Mike Frysinger <vapier@gentoo.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] clk: Implement clk_set_rate
Date: Mon, 30 May 2011 05:05:08 +0000 [thread overview]
Message-ID: <201105300105.10258.vapier@gentoo.org> (raw)
In-Reply-To: <1305876469.326620.351525457111.2.gpush@pororo>
[-- Attachment #1: Type: Text/Plain, Size: 382 bytes --]
On Friday, May 20, 2011 03:27:49 Jeremy Kerr wrote:
> int clk_set_rate(struct clk *clk, unsigned long rate)
> {
> - /* not yet implemented */
> - return -ENOSYS;
> + unsigned long parent_rate, new_rate;
> + int ret;
> +
> + if (!clk->ops->set_rate)
> + return -ENOSYS;
i thought ENOSYS is only for syscalls. shouldnt this be ENODEV or perhaps
EOPNOTSUPP ?
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mike Frysinger <vapier@gentoo.org>
To: Jeremy Kerr <jeremy.kerr@canonical.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/4] clk: Implement clk_set_rate
Date: Mon, 30 May 2011 01:05:08 -0400 [thread overview]
Message-ID: <201105300105.10258.vapier@gentoo.org> (raw)
In-Reply-To: <1305876469.326620.351525457111.2.gpush@pororo>
[-- Attachment #1: Type: Text/Plain, Size: 382 bytes --]
On Friday, May 20, 2011 03:27:49 Jeremy Kerr wrote:
> int clk_set_rate(struct clk *clk, unsigned long rate)
> {
> - /* not yet implemented */
> - return -ENOSYS;
> + unsigned long parent_rate, new_rate;
> + int ret;
> +
> + if (!clk->ops->set_rate)
> + return -ENOSYS;
i thought ENOSYS is only for syscalls. shouldnt this be ENODEV or perhaps
EOPNOTSUPP ?
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: vapier@gentoo.org (Mike Frysinger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] clk: Implement clk_set_rate
Date: Mon, 30 May 2011 01:05:08 -0400 [thread overview]
Message-ID: <201105300105.10258.vapier@gentoo.org> (raw)
In-Reply-To: <1305876469.326620.351525457111.2.gpush@pororo>
On Friday, May 20, 2011 03:27:49 Jeremy Kerr wrote:
> int clk_set_rate(struct clk *clk, unsigned long rate)
> {
> - /* not yet implemented */
> - return -ENOSYS;
> + unsigned long parent_rate, new_rate;
> + int ret;
> +
> + if (!clk->ops->set_rate)
> + return -ENOSYS;
i thought ENOSYS is only for syscalls. shouldnt this be ENODEV or perhaps
EOPNOTSUPP ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110530/64fac7f1/attachment.sig>
next prev parent reply other threads:[~2011-05-30 5:05 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 7:27 [PATCH 0/4] Add a generic struct clk Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` [PATCH 4/4] clk: Add simple gated clock Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 11:37 ` Arnd Bergmann
2011-05-20 11:37 ` Arnd Bergmann
2011-05-20 11:37 ` Arnd Bergmann
2011-05-20 22:19 ` Rob Herring
2011-05-20 22:19 ` Rob Herring
2011-05-20 22:19 ` Rob Herring
2011-05-20 7:27 ` [PATCH 2/4] clk: Implement clk_set_rate Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 12:25 ` Sascha Hauer
2011-05-20 12:25 ` Sascha Hauer
2011-05-20 12:25 ` Sascha Hauer
2011-05-24 7:59 ` Colin Cross
2011-05-24 7:59 ` Colin Cross
2011-05-24 7:59 ` Colin Cross
2011-05-25 19:03 ` Sascha Hauer
2011-05-25 19:03 ` Sascha Hauer
2011-05-25 19:03 ` Sascha Hauer
[not found] ` <1306373867.2875.162.camel@pororo>
2011-05-26 6:54 ` Sascha Hauer
2011-05-26 6:54 ` Sascha Hauer
2011-05-26 6:54 ` Sascha Hauer
2011-05-30 5:05 ` Mike Frysinger [this message]
2011-05-30 5:05 ` Mike Frysinger
2011-05-30 5:05 ` Mike Frysinger
2011-05-20 7:27 ` [PATCH 3/4] clk: Add fixed-rate clock Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-24 7:01 ` Francesco VIRLINZI
2011-05-30 5:01 ` Mike Frysinger
2011-05-30 5:01 ` Mike Frysinger
2011-05-30 5:01 ` Mike Frysinger
2011-05-30 5:02 ` Mike Frysinger
2011-05-30 5:02 ` Mike Frysinger
2011-05-30 5:02 ` Mike Frysinger
2011-05-20 7:27 ` [PATCH 1/4] clk: Add a generic clock infrastructure Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 11:59 ` Sascha Hauer
2011-05-20 11:59 ` Sascha Hauer
2011-05-20 11:59 ` Sascha Hauer
2011-05-20 13:25 ` Thomas Gleixner
2011-05-20 13:25 ` Thomas Gleixner
2011-05-20 13:25 ` Thomas Gleixner
2011-05-20 13:36 ` Sascha Hauer
2011-05-20 13:36 ` Sascha Hauer
2011-05-20 13:36 ` Sascha Hauer
2011-05-23 23:55 ` Colin Cross
2011-05-23 23:55 ` Colin Cross
2011-05-23 23:55 ` Colin Cross
2011-05-24 7:02 ` Sascha Hauer
2011-05-24 7:02 ` Sascha Hauer
2011-05-24 7:02 ` Sascha Hauer
2011-05-24 7:51 ` Colin Cross
2011-05-24 7:51 ` Colin Cross
2011-05-24 7:51 ` Colin Cross
2011-05-24 8:38 ` Sascha Hauer
2011-05-24 8:38 ` Sascha Hauer
2011-05-24 8:38 ` Sascha Hauer
2011-05-25 11:22 ` Richard Zhao
2011-05-25 11:22 ` Richard Zhao
2011-05-25 11:22 ` Richard Zhao
2011-05-25 11:43 ` Thomas Gleixner
2011-05-25 11:43 ` Thomas Gleixner
2011-05-25 11:43 ` Thomas Gleixner
2011-05-24 4:18 ` viresh kumar
2011-05-24 4:30 ` viresh kumar
2011-05-24 4:18 ` viresh kumar
2011-05-25 10:47 ` Richard Zhao
2011-05-25 10:47 ` Richard Zhao
2011-05-25 10:47 ` Richard Zhao
2011-05-30 5:00 ` Mike Frysinger
2011-05-30 5:00 ` Mike Frysinger
2011-05-30 5:00 ` Mike Frysinger
2011-05-23 23:12 ` [PATCH 0/4] Add a generic struct clk Colin Cross
2011-05-23 23:12 ` Colin Cross
2011-05-23 23:12 ` Colin Cross
2011-05-24 6:26 ` Sascha Hauer
2011-05-24 6:26 ` Sascha Hauer
2011-05-24 6:26 ` Sascha Hauer
2011-05-24 7:31 ` Colin Cross
2011-05-24 7:31 ` Colin Cross
2011-05-24 7:31 ` Colin Cross
2011-05-24 8:09 ` Sascha Hauer
2011-05-24 8:09 ` Sascha Hauer
2011-05-24 8:09 ` Sascha Hauer
2011-05-24 19:41 ` Colin Cross
2011-05-24 19:41 ` Colin Cross
2011-05-24 19:41 ` Colin Cross
2011-05-25 2:32 ` Richard Zhao
2011-05-25 2:32 ` Richard Zhao
2011-05-25 2:32 ` Richard Zhao
2011-05-25 6:23 ` Sascha Hauer
2011-05-25 6:23 ` Sascha Hauer
2011-05-25 6:23 ` Sascha Hauer
2011-05-25 7:51 ` Thomas Gleixner
2011-05-25 7:51 ` Thomas Gleixner
2011-05-25 7:51 ` Thomas Gleixner
2011-05-27 14:39 ` Mark Brown
2011-05-27 14:39 ` Mark Brown
2011-05-27 14:39 ` Mark Brown
2011-05-24 17:22 ` Richard Zhao
2011-05-24 17:22 ` Richard Zhao
2011-05-24 17:22 ` Richard Zhao
2011-05-24 17:52 ` Colin Cross
2011-05-24 17:52 ` Colin Cross
2011-05-24 17:52 ` Colin Cross
2011-05-25 2:08 ` Richard Zhao
2011-05-25 2:08 ` Richard Zhao
2011-05-25 2:08 ` Richard Zhao
2011-05-30 5:20 ` Mike Frysinger
2011-05-30 5:20 ` Mike Frysinger
2011-05-30 5:20 ` Mike Frysinger
2011-07-10 9:09 ` Mark Brown
2011-07-10 9:09 ` Mark Brown
2011-07-10 9:09 ` Mark Brown
2011-07-10 9:50 ` Russell King - ARM Linux
2011-07-10 9:50 ` Russell King - ARM Linux
2011-07-10 9:50 ` Russell King - ARM Linux
2011-07-10 10:00 ` Russell King - ARM Linux
2011-07-10 10:00 ` Russell King - ARM Linux
2011-07-10 10:00 ` Russell King - ARM Linux
2011-07-10 11:27 ` Mark Brown
2011-07-10 11:27 ` Mark Brown
2011-07-10 11:27 ` Mark Brown
2011-07-10 11:52 ` Russell King - ARM Linux
2011-07-10 11:52 ` Russell King - ARM Linux
2011-07-10 11:52 ` Russell King - ARM Linux
2011-07-11 2:49 ` Jeremy Kerr
2011-07-11 2:49 ` Jeremy Kerr
2011-07-11 2:49 ` Jeremy Kerr
2011-07-11 3:57 ` Mark Brown
2011-07-11 3:57 ` Mark Brown
2011-07-11 3:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105300105.10258.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.