All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Len Brown <lenb@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Len Brown <len.brown@intel.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, stable@kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: linux-next: build warningiIn Linus' tree
Date: Mon, 30 May 2011 09:34:45 +0200	[thread overview]
Message-ID: <20110530073445.GA27557@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.02.1105292346340.10035@arrandale.kernel.org>


* Len Brown <lenb@kernel.org> wrote:

> From: Len Brown <len.brown@intel.com>
> Date: Sun, 29 May 2011 23:38:15 -0400
> Subject: [PATCH] x86 idle: fix build warning for WARN_ONCE("idle=mwait")
> 
> In 5d4c47e0195b989f284907358bd5c268a44b91c7
> "x86 idle: deprecate mwait_idle() and "idle=mwait" cmdline param"...
> 
> I fat-fingered the editing when I updated the WARN_ONCE() string:
> 
> arch/x86/kernel/process.c: In function 'idle_setup':
> arch/x86/kernel/process.c:645:1: warning: unknown escape sequence: '\i'
> 
> remove the '\n' while we are here, it works fine without it.
> 
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
>  arch/x86/kernel/process.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Len, i'd *really* prefer it if patches changing arch/x86/ had a 
longer test time in linux-next than what you are gave it here.

This kind of 'send them to lkml and merge them into your linux-next 
branch and send it to Linus on the same day' kind of ambush you have 
done with the 'x86 idle' patches might be convenient to you, but it 
is inconvenient to pretty much anyone else - and it is absolutely 
unacceptable to us x86 maintainers ...

*Especially* as these patches were contentious when you last posted 
them as an RFC to lkml ...

So please watch out for this in the future, ok?

Thanks,

	Ingo

  reply	other threads:[~2011-05-30  7:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30  1:48 linux-next: build warningiIn Linus' tree Stephen Rothwell
2011-05-30  3:47 ` Len Brown
2011-05-30  7:34   ` Ingo Molnar [this message]
2011-05-30 19:11     ` Brown, Len
2011-05-30 19:23       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110530073445.GA27557@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.