From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v2 6/8] kvm tools: Add rwlock wrapper
Date: Mon, 30 May 2011 11:56:45 +0200
Message-ID: <20110530095645.GC8461@elte.hu>
References: <1306744247-26051-1-git-send-email-levinsasha928@gmail.com>
 <1306744247-26051-6-git-send-email-levinsasha928@gmail.com>
 <20110530084309.GH30513@elte.hu>
 <BANLkTimURb9XnOxd_comq6FEhqDOiLreWg@mail.gmail.com>
 <1306748069.14564.52.camel@lappy>
 <BANLkTin7mAbLG_bbqxkUen0S6dzEc04NEQ@mail.gmail.com>
 <1306748796.14564.62.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pekka Enberg <penberg@kernel.org>, kvm@vger.kernel.org,
	asias.hejun@gmail.com, gorcunov@gmail.com,
	prasadjoshi124@gmail.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:44190 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754721Ab1E3J44 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 30 May 2011 05:56:56 -0400
Content-Disposition: inline
In-Reply-To: <1306748796.14564.62.camel@lappy>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Sasha Levin <levinsasha928@gmail.com> wrote:

> I'm just saying that we're limited to as many VCPU threads as we 
> can create. br_read_lock() won't do anything on a non-VCPU thread, 
> which makes it impossible to test it on non-VCPUs.

btw., i wondered about that limit - don't we want to fix it?

I mean, there's no fundamental reason why brlocks should do 'nothing' 
in worker threads. In fact it's a subtle breakage waiting AFAICS.

We should have enumeration for all threads that kvm starts, and that 
we can use for a generic pause/resume facility. Can you see anything 
that prevents that model?

Thanks,

	Ingo