From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Suraj Sumangala <suraj@atheros.com>
Cc: linux-bluetooth@vger.kernel.org, Jothikumar.Mothilal@Atheros.com
Subject: Re: [PATCH] Bluetooth: Support SCO over HCI for Atheros AR300x Bluetooth device
Date: Mon, 30 May 2011 16:02:13 -0300 [thread overview]
Message-ID: <20110530190213.GC2556@joana> (raw)
In-Reply-To: <1305878771-26464-1-git-send-email-suraj@atheros.com>
Hi Suraj,
* Suraj Sumangala <suraj@atheros.com> [2011-05-20 13:36:11 +0530]:
> This patch adds SCO over HCI support to Atheros AR300x HCI transport
> driver.
>
> Signed-off-by: Suraj Sumangala <suraj@atheros.com>
> ---
> drivers/bluetooth/hci_ath.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
> index 4093935..8e15c31 100644
> --- a/drivers/bluetooth/hci_ath.c
> +++ b/drivers/bluetooth/hci_ath.c
> @@ -162,11 +162,6 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)
> {
> struct ath_struct *ath = hu->priv;
>
> - if (bt_cb(skb)->pkt_type == HCI_SCODATA_PKT) {
> - kfree_skb(skb);
> - return 0;
> - }
> -
> /*
> * Update power management enable flag with parameters of
> * HCI sleep enable vendor specific HCI command.
> @@ -184,9 +179,14 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)
> memcpy(skb_push(skb, 1), &bt_cb(skb)->pkt_type, 1);
>
> skb_queue_tail(&ath->txq, skb);
> - set_bit(HCI_UART_SENDING, &hu->tx_state);
>
> - schedule_work(&ath->ctxtsw);
> + if (bt_cb(skb)->pkt_type == HCI_SCODATA_PKT) {
> + clear_bit(HCI_UART_SENDING, &hu->tx_state);
> + hci_uart_tx_wakeup(hu);
We can't do that, prioritize SCO over HCI Events. This can lead to weird sync
problems, so please remove this and send me a new patch.
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2011-05-30 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 8:06 [PATCH] Bluetooth: Support SCO over HCI for Atheros AR300x Bluetooth device Suraj Sumangala
2011-05-30 19:02 ` Gustavo F. Padovan [this message]
2011-05-31 5:07 ` Sumangala, Suraj
2011-05-31 5:16 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2011-01-28 10:49 Suraj Sumangala
2011-01-31 17:28 ` Suraj Sumangala
2011-02-02 16:16 ` Gustavo F. Padovan
2011-02-02 16:31 ` Suraj Sumangala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530190213.GC2556@joana \
--to=padovan@profusion.mobi \
--cc=Jothikumar.Mothilal@Atheros.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=suraj@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.