From: Oleg Nesterov <oleg@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] ptrace: unify show_regs() prototype
Date: Mon, 30 May 2011 21:07:13 +0200 [thread overview]
Message-ID: <20110530190713.GA20616@redhat.com> (raw)
In-Reply-To: <1306726753-16128-1-git-send-email-vapier@gentoo.org>
On 05/29, Mike Frysinger wrote:
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> andrew: can you pick this up ? sent a few months ago w/no love.
The patch looks obviously fine, I can put it into ptrace tree.
Cough. Yes it is simple, but perhaps it still needs the changelog?
Even a single line.
One nit,
> --- a/include/linux/ptrace.h
> +++ b/include/linux/ptrace.h
> @@ -100,6 +100,7 @@
> #include <linux/sched.h> /* For struct task_struct. */
>
>
> +extern void show_regs(struct pt_regs *);
Not sure ptrace.h is the right place. show_regs() has the callers which
have nothing to do with ptrace.
Hmm. You know what? show_regs() is already defined in sched.h, probably
you can simply remove this chunk.
Oleg.
next prev parent reply other threads:[~2011-05-30 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 5:38 [PATCH] ptrace: unify show_regs() prototype Mike Frysinger
2011-05-30 3:39 ` Mike Frysinger
2011-05-30 19:07 ` Oleg Nesterov [this message]
2011-05-30 22:54 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530190713.GA20616@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.