From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org
Subject: [PATCH] ALSA: isight: add now required waking of DMA context
Date: Tue, 31 May 2011 11:07:50 +0200 [thread overview]
Message-ID: <20110531110750.00a03563@stein> (raw)
Since commit 13882a82ee16, upper-layer firewire drivers are required to
flush after enqueueing a batch of isochronous buffers.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Actually, snd-isight still worked for me without it but I guess I was
just lucky that the controllers (FW643-e, JMB381, XIO2213A) never read
up to the current tail of the DMA program.
Dismiss this if you already have something like this in the pipeline.
sound/firewire/isight.c | 1 +
1 file changed, 1 insertion(+)
Index: b/sound/firewire/isight.c
===================================================================
--- a/sound/firewire/isight.c
+++ b/sound/firewire/isight.c
@@ -213,6 +213,7 @@ static void isight_packet(struct fw_iso_
if (++index >= QUEUE_LENGTH)
index = 0;
isight->packet_index = index;
+ fw_iso_context_queue_flush(isight->context);
}
static int isight_connect(struct isight *isight)
--
Stefan Richter
-=====-==-== -=-= =====
http://arcgraph.de/sr/
next reply other threads:[~2011-05-31 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 9:07 Stefan Richter [this message]
2011-06-22 6:59 ` [PATCH 3.0-rc1 resend] ALSA: isight: add now required waking of DMA context Stefan Richter
2011-06-22 7:05 ` Clemens Ladisch
2011-06-22 12:30 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531110750.00a03563@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.