From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932305Ab1EaRe1 (ORCPT ); Tue, 31 May 2011 13:34:27 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:51204 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757547Ab1EaRe0 (ORCPT ); Tue, 31 May 2011 13:34:26 -0400 Date: Tue, 31 May 2011 18:33:48 +0100 From: Al Viro To: Sage Weil Cc: Christoph Hellwig , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [git pull] dentry_unhash() breakage Message-ID: <20110531173348.GL11521@ZenIV.linux.org.uk> References: <20110530020604.GC561@dastard> <20110530034741.GD561@dastard> <20110530055601.GK11521@ZenIV.linux.org.uk> <20110530085922.GA11336@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2011 at 09:26:52AM -0700, Sage Weil wrote: > On Mon, 30 May 2011, Christoph Hellwig wrote: > > On Mon, May 30, 2011 at 06:56:01AM +0100, Al Viro wrote: > > > A couple of dentry_unhash fallout fixes > > > > Shouldn't we do the shrink_dcache_parent only after a successfull > > rmdir or rename? > > Yeah, that makes more sense to me... No, it doesn't. Let's keep changes to minimum. I *really* don't want to audit autofs and hell knows how many other places for more or less subtle breakage caused by that. It's bad enough as it is... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p4VHYTTL056963 for ; Tue, 31 May 2011 12:34:30 -0500 Received: from ZenIV.linux.org.uk (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 54C0214E1D08 for ; Tue, 31 May 2011 10:34:27 -0700 (PDT) Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) by cuda.sgi.com with ESMTP id cueifgHRRIByDMsC for ; Tue, 31 May 2011 10:34:27 -0700 (PDT) Date: Tue, 31 May 2011 18:33:48 +0100 From: Al Viro Subject: Re: [git pull] dentry_unhash() breakage Message-ID: <20110531173348.GL11521@ZenIV.linux.org.uk> References: <20110530020604.GC561@dastard> <20110530034741.GD561@dastard> <20110530055601.GK11521@ZenIV.linux.org.uk> <20110530085922.GA11336@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Sage Weil Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, xfs@oss.sgi.com On Tue, May 31, 2011 at 09:26:52AM -0700, Sage Weil wrote: > On Mon, 30 May 2011, Christoph Hellwig wrote: > > On Mon, May 30, 2011 at 06:56:01AM +0100, Al Viro wrote: > > > A couple of dentry_unhash fallout fixes > > > > Shouldn't we do the shrink_dcache_parent only after a successfull > > rmdir or rename? > > Yeah, that makes more sense to me... No, it doesn't. Let's keep changes to minimum. I *really* don't want to audit autofs and hell knows how many other places for more or less subtle breakage caused by that. It's bad enough as it is... _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs