From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 2/2] omap3: iovmm: Support non page-aligned buffers in iommu_vmap Date: Wed, 1 Jun 2011 06:10:52 -0700 Message-ID: <20110601131052.GF11352@atomide.com> References: <20110531132233.GQ11352@atomide.com> <1306931102-10943-2-git-send-email-laurent.pinchart@ideasonboard.com> <20110601125024.GD11352@atomide.com> <201106011509.05514.laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:51632 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750753Ab1FANKy (ORCPT ); Wed, 1 Jun 2011 09:10:54 -0400 Content-Disposition: inline In-Reply-To: <201106011509.05514.laurent.pinchart@ideasonboard.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Laurent Pinchart Cc: linux-omap@vger.kernel.org * Laurent Pinchart [110601 06:04]: > On Wednesday 01 June 2011 14:50:24 Tony Lindgren wrote: > > * Laurent Pinchart [110601 05:21]: > > > The IOMMU virtual memory mapping API requires page-aligned buffers. > > > There's no hardware reason behind such a restriction. Remove it by > > > rounding the address of the first page entry down, and adding the offset > > > back to the IOMMU virtual address. > > > > Does this one also fix some bug? > > Yes, but no oops. It fixes an OMAP3 ISP failure when the buffer passed from > userspace is not page-aligned. OK, thanks. I'll update the description with that and apply both to devel-fixes. Tony