All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Petter Selasky <hselasky@c2i.net>
To: Lutz Sammer <johns98@gmx.net>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v3 - resend] Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend.
Date: Thu, 2 Jun 2011 12:03:47 +0200	[thread overview]
Message-ID: <201106021203.47366.hselasky@c2i.net> (raw)
In-Reply-To: <4DE75BE7.4050403@gmx.net>

On Thursday 02 June 2011 11:46:15 Lutz Sammer wrote:
> Hello Hans Petter,

Hi,

> 
> I haven't tested your patch yet, but looking at the source I see some
> problems.
> 
> What does your patch fix and how?

It switches from software derot to hardware derot, by writing zero to the 
derot register.

> 
> If you have problem locking channels, try my locking patch:
> https://patchwork.kernel.org/patch/753382/
> 
> On each step (timing, carrier, data) you reset the derot:
>      stb0899_set_derot(state, 0);
> Why?

I have no good reason. It just works.

> 
> Afaik you destroy already locked frequencies, which slows
> down the locking.
> 
> Than you do 8 loops:
>     for (index = 0; index < 8; index++) {
> Why?

> 
> All checks already contains some delays, if the delays are too
> short, you should fix this delays.

I can test patches regarding channel locking. The initial problem was the the 
stb0899 driver would not tune any channels.

--HPS

  reply	other threads:[~2011-06-02 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02  9:46 [PATCH v3 - resend] Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend Lutz Sammer
2011-06-02 10:03 ` Hans Petter Selasky [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-28 13:16 Hans Petter Selasky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106021203.47366.hselasky@c2i.net \
    --to=hselasky@c2i.net \
    --cc=johns98@gmx.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.