All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Chetan Loke <loke.chetan@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	eric.dumazet@gmail.com, kaber@trash.net,
	johann.baudy@gnu-log.net, Chetan Loke <lokec@ccs.neu.edu>
Subject: Re: [af-packet 1/2] Enhance af-packet to provide (near zero)lossless packet capture functionality.
Date: Wed, 8 Jun 2011 09:03:05 -0700	[thread overview]
Message-ID: <20110608090305.370f5857@nehalam.ftrdhcpuser.net> (raw)
In-Reply-To: <1307502786-1396-2-git-send-email-loke.chetan@gmail.com>

On Tue,  7 Jun 2011 23:13:05 -0400
Chetan Loke <loke.chetan@gmail.com> wrote:

> --- a/include/linux/if_packet.h
> +++ b/include/linux/if_packet.h
> @@ -24,7 +24,7 @@ struct sockaddr_ll {
>  #define PACKET_HOST		0		/* To us		*/
>  #define PACKET_BROADCAST	1		/* To all		*/
>  #define PACKET_MULTICAST	2		/* To group		*/
> -#define PACKET_OTHERHOST	3		/* To someone else 	*/
> +#define PACKET_OTHERHOST	3		/* To someone else	*/

Useless whitespace change in patch. It makes sense to review the resulting
diff and avoid this kind of stuff creeping in.

  parent reply	other threads:[~2011-06-08 17:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08  3:13 [af-packet 0/2] Enhance af-packet to provide (near zero)lossless packet capture functionality Chetan Loke
2011-06-08  3:13 ` [af-packet 1/2] " Chetan Loke
2011-06-08  4:35   ` Eric Dumazet
2011-06-08 22:10     ` chetan loke
2011-06-08 22:22       ` Eric Dumazet
2011-06-08 16:03   ` Stephen Hemminger [this message]
2011-06-08  3:13 ` [af-packet 2/2] " Chetan Loke
2011-06-08  4:18   ` Joe Perches
2011-06-08 22:01     ` chetan loke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110608090305.370f5857@nehalam.ftrdhcpuser.net \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=johann.baudy@gnu-log.net \
    --cc=kaber@trash.net \
    --cc=loke.chetan@gmail.com \
    --cc=lokec@ccs.neu.edu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.