From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v2 2/5] net: ep93xx_eth: pass struct device to DMA API functions Date: Fri, 10 Jun 2011 19:55:45 +0300 Message-ID: <20110610165545.GA2753@acer> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@wantstofly.org" , rmallon@gmail.com To: H Hartley Sweeten Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:44510 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107Ab1FJQ6R (ORCPT ); Fri, 10 Jun 2011 12:58:17 -0400 Received: by ewy4 with SMTP id 4so972408ewy.19 for ; Fri, 10 Jun 2011 09:58:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jun 09, 2011 at 06:40:21PM -0500, H Hartley Sweeten wrote: > > I just noticed this macro in include/linux/netdevice.h > > /* Set the sysfs physical device reference for the network logical device > * if set prior to registration will cause a symlink during initialization. > */ > #define SET_NETDEV_DEV(net, pdev) ((net)->dev.parent = (pdev)) > > Is there anyway you could use that macro in the probe to save the platform_device > (with it's associated device) instead of introducing a new struct device * in the > private data? Nice finding, thanks. I'll look into that and send new version of the whole series soon. From mboxrd@z Thu Jan 1 00:00:00 1970 From: mika.westerberg@iki.fi (Mika Westerberg) Date: Fri, 10 Jun 2011 19:55:45 +0300 Subject: [PATCH v2 2/5] net: ep93xx_eth: pass struct device to DMA API functions In-Reply-To: References: Message-ID: <20110610165545.GA2753@acer> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 09, 2011 at 06:40:21PM -0500, H Hartley Sweeten wrote: > > I just noticed this macro in include/linux/netdevice.h > > /* Set the sysfs physical device reference for the network logical device > * if set prior to registration will cause a symlink during initialization. > */ > #define SET_NETDEV_DEV(net, pdev) ((net)->dev.parent = (pdev)) > > Is there anyway you could use that macro in the probe to save the platform_device > (with it's associated device) instead of introducing a new struct device * in the > private data? Nice finding, thanks. I'll look into that and send new version of the whole series soon.