Re: N900 USB fix (Was: Re: [PATCH/RFC 2/6] OMAP2+: PM: move runtime PM implementation to use device power domains)

From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Jarkko Nikula <jhnikula@gmail.com>,
	Kalle Jokiniemi <kalle.jokiniemi@nokia.com>,
	Kevin Hilman <khilman@ti.com>,
	linux-omap@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>,
	Heikki Krogerus <heikki.krogerus@nokia.com>
Subject: Re: N900 USB fix (Was: Re: [PATCH/RFC 2/6] OMAP2+: PM: move runtime PM implementation to use device power domains)
Date: Mon, 13 Jun 2011 11:47:48 +0300	[thread overview]
Message-ID: <20110613084746.GC3633@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20110613084601.GB3633@legolas.emea.dhcp.ti.com>

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

Hi,

On Mon, Jun 13, 2011 at 11:46:04AM +0300, Felipe Balbi wrote:
> On Mon, Jun 13, 2011 at 11:28:20AM +0300, Jarkko Nikula wrote:
> > On Fri, 10 Jun 2011 09:57:57 +0300
> > Sakari Ailus <sakari.ailus@maxwell.research.nokia.com> wrote:
> > 
> > > > A fix has been posted (and pull req sent to Tony.)  Can you try my
> > > > for_3.0/pm-fixes branch which fixes this problem?  It's available in my
> > > > git tree:
> > > > 
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
> > > 
> > > Hi, Kevin!
> > > 
> > > Many thanks to you! :-) The patches indeed fix the problem. I seem to
> > > have used for_3.0/pm-fixes-2 branch, though. I guess that doesn't really
> > > matter. :-)
> > > 
> > I was struggling also with non-working musb on N900. I traced primary
> > breakage to the same commit than Sakari. On top of that commit the
> > Kevin's fix made it working but it didn't work on top of 3.0-rc2 while
> > beagle was ok.
> > 
> > I bisected another issue to commit 10299e2 ("ARM: RX-51: Enable isp1704
> > power on/off").
> > 
> > 3.0-rc2 works if I enable the CONFIG_CHARGER_ISP1704=y but do we
> > actually need to drive the ISP1704 into reset in
> > board-rx51-peripherals.c: rx51_charger_init as it breaks the musb when
> > the ISP1704 driver is missing and otherwise rx51_charger_set_power
> > should take care of ISP1704 reset control when the driver is there?
> 
> You might want to ask from Heikki. He patched that part of the code.

used wrong mail address for Heikki, fixing.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]