All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Thornber <thornber@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	"Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [PATCH 1/2] dm-kcopyd: introduce per-module throttle structure
Date: Mon, 13 Jun 2011 10:17:16 +0100	[thread overview]
Message-ID: <20110613091716.GC4580@ubuntu> (raw)
In-Reply-To: <Pine.LNX.4.64.1106100858280.32120@hs20-bc2-1.build.redhat.com>

On Sat, Jun 11, 2011 at 04:27:02PM -0400, Mikulas Patocka wrote:
> It is much easier to explain to the users "if you set X value in 
> /sys/module/dm_mirror/parameters/raid1_resync_throttle, then the copying 
> will be done in X% of time, leaving the disk idle 100-X% of time", then to 
> invent some magic mechanisms that change multiple things based on X and 
> other conditions.

Yes, that is very easy to explain to the users.  This sort of
description is what I was after when I kept asking you to tell me how
to set it.

It's not clear to me that setting the throttle to 80% will copy at 80%
of the speed, or leave the disk idle for 20% of the time.  Perhaps you
have some benchmarks to back this up?  (with different memory pressure
situations please).

Restricting the cpu available to issue io is not a great way to
throttle io.  There will be plenty of situations where 20% of the cpu
is enough to swamp the devices.

- Joe

  reply	other threads:[~2011-06-13  9:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 22:03 [PATCH 1/2] dm-kcopyd: introduce per-module throttle structure Mikulas Patocka
2011-06-01  6:18 ` Ankit Jain
2011-06-01  7:13   ` Ankit Jain
2011-06-02 19:16   ` Mikulas Patocka
2011-06-01  9:51 ` Joe Thornber
2011-06-02 19:55   ` Mikulas Patocka
2011-06-03 11:01     ` Joe Thornber
2011-06-03 15:54       ` Mike Snitzer
2011-06-07 17:50       ` Mikulas Patocka
2011-06-09  9:47         ` Joe Thornber
2011-06-09 16:08           ` Mikulas Patocka
2011-06-09 16:27             ` Alasdair G Kergon
2011-06-10  8:44             ` Joe Thornber
2011-06-10  9:28               ` Lars Ellenberg
2011-06-10 10:14                 ` Joe Thornber
2011-06-10 13:41                   ` Mikulas Patocka
2011-06-10 13:48                     ` Joe Thornber
2011-06-10 16:13                       ` Lars Ellenberg
2011-06-10 13:51                     ` Mike Snitzer
2011-06-11 20:27               ` Mikulas Patocka
2011-06-13  9:17                 ` Joe Thornber [this message]
2011-06-13 21:06                   ` Mikulas Patocka
2011-06-14  8:34                     ` Joe Thornber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110613091716.GC4580@ubuntu \
    --to=thornber@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.