From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 4/8] ARM: dma-mapping: implement dma sg methods on top of generic dma ops Date: Mon, 20 Jun 2011 15:40:12 +0100 Message-ID: <20110620144012.GE26089@n2100.arm.linux.org.uk> References: <1308556213-24970-1-git-send-email-m.szyprowski@samsung.com> <1308556213-24970-5-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1308556213-24970-5-git-send-email-m.szyprowski@samsung.com> Sender: owner-linux-mm@kvack.org To: Marek Szyprowski Cc: linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Kyungmin Park , Arnd Bergmann , Joerg Roedel List-Id: linux-arch.vger.kernel.org On Mon, Jun 20, 2011 at 09:50:09AM +0200, Marek Szyprowski wrote: > This patch converts all dma_sg methods to be generic (independent of the > current DMA mapping implementation for ARM architecture). All dma sg > operations are now implemented on top of respective > dma_map_page/dma_sync_single_for* operations from dma_map_ops structure. No. We really don't want to do this. If we want to move the dsb() out of the mapping functions (which I have a patch for) to avoid doing a dsb() on each and every sg segment, then we must not use the generic stuff. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:59928 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754378Ab1FTOk3 (ORCPT ); Mon, 20 Jun 2011 10:40:29 -0400 Date: Mon, 20 Jun 2011 15:40:12 +0100 From: Russell King - ARM Linux Subject: Re: [PATCH 4/8] ARM: dma-mapping: implement dma sg methods on top of generic dma ops Message-ID: <20110620144012.GE26089@n2100.arm.linux.org.uk> References: <1308556213-24970-1-git-send-email-m.szyprowski@samsung.com> <1308556213-24970-5-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1308556213-24970-5-git-send-email-m.szyprowski@samsung.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Marek Szyprowski Cc: linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Kyungmin Park , Arnd Bergmann , Joerg Roedel Message-ID: <20110620144012.gcR7stJ0G4WiikAEWV4qQubAp7h1t7nIzKTgbv5PSdw@z> On Mon, Jun 20, 2011 at 09:50:09AM +0200, Marek Szyprowski wrote: > This patch converts all dma_sg methods to be generic (independent of the > current DMA mapping implementation for ARM architecture). All dma sg > operations are now implemented on top of respective > dma_map_page/dma_sync_single_for* operations from dma_map_ops structure. No. We really don't want to do this. If we want to move the dsb() out of the mapping functions (which I have a patch for) to avoid doing a dsb() on each and every sg segment, then we must not use the generic stuff. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Mon, 20 Jun 2011 15:40:12 +0100 Subject: [PATCH 4/8] ARM: dma-mapping: implement dma sg methods on top of generic dma ops In-Reply-To: <1308556213-24970-5-git-send-email-m.szyprowski@samsung.com> References: <1308556213-24970-1-git-send-email-m.szyprowski@samsung.com> <1308556213-24970-5-git-send-email-m.szyprowski@samsung.com> Message-ID: <20110620144012.GE26089@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 20, 2011 at 09:50:09AM +0200, Marek Szyprowski wrote: > This patch converts all dma_sg methods to be generic (independent of the > current DMA mapping implementation for ARM architecture). All dma sg > operations are now implemented on top of respective > dma_map_page/dma_sync_single_for* operations from dma_map_ops structure. No. We really don't want to do this. If we want to move the dsb() out of the mapping functions (which I have a patch for) to avoid doing a dsb() on each and every sg segment, then we must not use the generic stuff.