From: Peter Zijlstra <a.p.zijlstra@chello.nl> To: Linus Torvalds <torvalds@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de> Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, efault@gmx.de Subject: [PATCH 0/4] printk: Remove lockdep_off() and wakeups -v3 Date: Tue, 21 Jun 2011 17:17:25 +0200 [thread overview] Message-ID: <20110621151725.705140475@chello.nl> (raw) Last iteration of the printk() rework which removes the lockdep_off() hackery and removes the need for printk() to issue wakeups, thereby increasing reliability from variuos contexts. Patch 0b5e1c5255 from -tip needs to be reverted (or better dropped), due us discovering why doing up() under logbuf_lock was important -- thanks Andrew, Ingo! This series was tested on a lockdep enabled kernel with the below hack included, which generated a nice splat. --- kernel/printk.c | 5 +++++ 1 file changed, 5 insertions(+) Index: linux-2.6/kernel/printk.c =================================================================== --- linux-2.6.orig/kernel/printk.c +++ linux-2.6/kernel/printk.c @@ -930,6 +930,11 @@ asmlinkage int vprintk(const char *fmt, spin_lock(&logbuf_lock); printk_cpu = this_cpu; + if (panic_timeout) { + panic_timeout = 0; + local_irq_enable(); + } + if (recursion_bug) { recursion_bug = 0; strcpy(printk_buf, recursion_bug_msg);
next reply other threads:[~2011-06-21 15:40 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-21 15:17 Peter Zijlstra [this message] 2011-06-21 15:17 ` [PATCH 1/4] printk: Release console_sem after logbuf_lock Peter Zijlstra 2011-06-21 15:17 ` [PATCH 2/4] lockdep: Fix trace_{soft,hard}irqs_{on,off}() recursion Peter Zijlstra 2011-06-22 15:13 ` [tip:core/printk] lockdep: Fix trace_[soft,hard]irqs_[on,off]() recursion tip-bot for Peter Zijlstra 2011-06-21 15:17 ` [PATCH 3/4] printk, lockdep: Remove lockdep_off() usage Peter Zijlstra 2011-06-21 15:17 ` [PATCH 4/4] printk: Avoid all wakeups from printk Peter Zijlstra 2011-06-22 9:20 ` [PATCH 0/4] printk: Remove lockdep_off() and wakeups -v3 Peter Zijlstra 2011-06-22 11:50 ` Ingo Molnar 2011-06-22 13:44 ` Peter Zijlstra 2011-06-22 14:22 ` [tip:core/printk] printk: Fix console_sem vs logbuf_lock unlock race tip-bot for Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110621151725.705140475@chello.nl \ --to=a.p.zijlstra@chello.nl \ --cc=akpm@linux-foundation.org \ --cc=efault@gmx.de \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --subject='Re: [PATCH 0/4] printk: Remove lockdep_off() and wakeups -v3' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.