From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mfd: Add I2C control support for S5M8751
Date: Wed, 22 Jun 2011 13:50:50 +0100 [thread overview]
Message-ID: <20110622125050.GE23666@sirena.org.uk> (raw)
In-Reply-To: <1308722037-6966-4-git-send-email-sbkim73@samsung.com>
On Wed, Jun 22, 2011 at 02:53:57PM +0900, Sangbeom Kim wrote:
> Implement the I2C control interface for the S5M8751.
>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
If the device doesn't support SPI this could just as well be merged into
the main driver - the reason for splitting with devices that support
both is that it gives more flexibility with what gets built into the
core kernel when both APIs are enabled.
> +static int s5m8751_i2c_read_device(struct s5m8751 *s5m8751, uint8_t reg,
> + uint8_t *val)
> +{
> + int ret;
> + ret = i2c_smbus_read_byte_data(s5m8751->i2c_client, reg);
> + if (ret < 0) {
> + dev_err(s5m8751->dev, "failed reading at 0x%02x\n", reg);
> + return ret;
> + }
> + *val = (uint8_t)ret;
Why is this case required?
next prev parent reply other threads:[~2011-06-22 12:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 5:53 [PATCH 0/3] S5M8751 core driver Sangbeom Kim
2011-06-22 5:53 ` [PATCH 1/3] mfd: Add S5M8751 register definitions Sangbeom Kim
2011-06-22 12:42 ` Mark Brown
2011-06-22 23:59 ` Sangbeom Kim
2011-06-22 5:53 ` [PATCH 2/3] mfd: Add initial S5M8751 support Sangbeom Kim
2011-06-22 12:48 ` Mark Brown
2011-06-23 1:14 ` Sangbeom Kim
2011-07-04 14:07 ` Samuel Ortiz
2011-07-04 23:49 ` Sangbeom Kim
2011-06-22 5:53 ` [PATCH 3/3] mfd: Add I2C control support for S5M8751 Sangbeom Kim
2011-06-22 8:56 ` Maxin B John
2011-06-22 12:50 ` Mark Brown [this message]
2011-06-23 1:25 ` Sangbeom Kim
2011-06-23 1:28 ` Mark Brown
2011-06-23 2:21 ` Sangbeom Kim
2011-06-23 10:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622125050.GE23666@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.