From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758083Ab1FVPq7 (ORCPT ); Wed, 22 Jun 2011 11:46:59 -0400 Received: from sous-sol.org ([216.99.217.87]:36203 "EHLO sequoia.sous-sol.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757978Ab1FVPq5 (ORCPT ); Wed, 22 Jun 2011 11:46:57 -0400 Date: Wed, 22 Jun 2011 08:46:30 -0700 From: Chris Wright To: Izik Eidus Cc: Chris Wright , Nai Xia , Andrew Morton , Andrea Arcangeli , Hugh Dickins , Rik van Riel , linux-mm , Johannes Weiner , linux-kernel , kvm , mtosatti@redhat.com Subject: Re: [PATCH] mmu_notifier, kvm: Introduce dirty bit tracking in spte and mmu notifier to help KSM dirty bit tracking Message-ID: <20110622154630.GT25383@sequoia.sous-sol.org> References: <201106212055.25400.nai.xia@gmail.com> <201106212132.39311.nai.xia@gmail.com> <20110622002123.GP25383@sequoia.sous-sol.org> <4E018897.7040707@ravellosystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E018897.7040707@ravellosystems.com> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Izik Eidus (izik.eidus@ravellosystems.com) wrote: > On 6/22/2011 3:21 AM, Chris Wright wrote: > >* Nai Xia (nai.xia@gmail.com) wrote: > >>+ if (!shadow_dirty_mask) { > >>+ WARN(1, "KVM: do NOT try to test dirty bit in EPT\n"); > >>+ goto out; > >>+ } > >This should never fire with the dirty_update() notifier test, right? > >And that means that this whole optimization is for the shadow mmu case, > >arguably the legacy case. > > Hi Chris, > AMD npt does track the dirty bit in the nested page tables, > so the shadow_dirty_mask should not be 0 in that case... Yeah, momentary lapse... ;) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wright Subject: Re: [PATCH] mmu_notifier, kvm: Introduce dirty bit tracking in spte and mmu notifier to help KSM dirty bit tracking Date: Wed, 22 Jun 2011 08:46:30 -0700 Message-ID: <20110622154630.GT25383@sequoia.sous-sol.org> References: <201106212055.25400.nai.xia@gmail.com> <201106212132.39311.nai.xia@gmail.com> <20110622002123.GP25383@sequoia.sous-sol.org> <4E018897.7040707@ravellosystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Wright , Nai Xia , Andrew Morton , Andrea Arcangeli , Hugh Dickins , Rik van Riel , linux-mm , Johannes Weiner , linux-kernel , kvm , mtosatti@redhat.com To: Izik Eidus Return-path: Content-Disposition: inline In-Reply-To: <4E018897.7040707@ravellosystems.com> Sender: owner-linux-mm@kvack.org List-Id: kvm.vger.kernel.org * Izik Eidus (izik.eidus@ravellosystems.com) wrote: > On 6/22/2011 3:21 AM, Chris Wright wrote: > >* Nai Xia (nai.xia@gmail.com) wrote: > >>+ if (!shadow_dirty_mask) { > >>+ WARN(1, "KVM: do NOT try to test dirty bit in EPT\n"); > >>+ goto out; > >>+ } > >This should never fire with the dirty_update() notifier test, right? > >And that means that this whole optimization is for the shadow mmu case, > >arguably the legacy case. > > Hi Chris, > AMD npt does track the dirty bit in the nested page tables, > so the shadow_dirty_mask should not be 0 in that case... Yeah, momentary lapse... ;) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org