From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
From: Szymon Janc <szymon.janc@tieto.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Subject: Re: [PATCH hcidump 1/3] Add basic AVCTP parsing
Date: Fri, 24 Jun 2011 11:24:45 +0200
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
References: <1308752563-16991-1-git-send-email-luiz.dentz@gmail.com>
In-Reply-To: <1308752563-16991-1-git-send-email-luiz.dentz@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Message-Id: <201106241124.45874.szymon.janc@tieto.com>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Luiz,

> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> ---
>  parser/avctp.c  |   29 +++++++++++++++++++++++++++--
>  parser/parser.h |    1 +
>  2 files changed, 28 insertions(+), 2 deletions(-)
> 
> diff --git a/parser/avctp.c b/parser/avctp.c
> index 4a8876c..aa2def1 100644
> --- a/parser/avctp.c
> +++ b/parser/avctp.c
> @@ -36,10 +36,35 @@
>  
>  #include "parser.h"
>  
> +static char *pt2str(uint8_t hdr)
> +{
> +	switch (hdr & 0x0c) {
> +	case 0x00:
> +		return "";
> +	case 0x04:
> +		return "Start";
> +	case 0x08:
> +		return "Cont";
> +	case 0x0c:
> +		return "End";
> +	default:
> +		return "Unk";
> +	}
> +}
> +
>  void avctp_dump(int level, struct frame *frm)
>  {
> +	uint8_t hdr;
> +	uint16_t pid;
> +
>  	p_indent(level, frm);
> -	printf("AVCTP:\n");
>  
> -	raw_dump(level, frm);
> +	hdr = get_u8(frm);
> +	pid = get_u16(frm);
> +
> +	printf("AVCTP: %s %s: pt 0x%02x transaction %d pid 0x%04x \n",
> +				hdr & 0x02 ? "Response" : "Command",
> +				pt2str(hdr), hdr & 0x0c, hdr >> 4, pid);
> +
> +	raw_dump(level + 1, frm);
>  }
> diff --git a/parser/parser.h b/parser/parser.h
> index bbdfc01..cf40034 100644
> --- a/parser/parser.h
> +++ b/parser/parser.h
> @@ -231,6 +231,7 @@ void hidp_dump(int level, struct frame *frm);
>  void hcrp_dump(int level, struct frame *frm);
>  void avdtp_dump(int level, struct frame *frm);
>  void avctp_dump(int level, struct frame *frm);
> +void avrcp_dump(int level, struct frame *frm);

Shouldn't this go to "[PATCH hcidump 2/3] Add basic AVRCP parsing" ?

>  void att_dump(int level, struct frame *frm);
>  void smp_dump(int level, struct frame *frm);
>  

-- 
BR
Szymon Janc