All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: axboe@kernel.dk, rjw@sisk.pl
Subject: Linux 3.0 oopses when pulling a USB CDROM
Date: Fri, 1 Jul 2011 10:05:31 -0700	[thread overview]
Message-ID: <20110701170531.GA3693@tassilo.jf.intel.com> (raw)

Hi,

I found I can reliably crash a 3.0 system by pulling the
USB cable of a mounted USB cdrom (or rather a USB device which
has a builtin fake CD-ROM) 

I suspect it's a regression too.

It ends with a NULL pointer reference on a NULL sdev in 
scsi_prep_state_check. 

Here's a somewhat incomplete backtrace (written down by hand)

scsi_prep_state_check
scsi_setup_blk_pc_cmnd
blk_peek_request
...
scsi_request_fn
...
ioctl_internal_command
...
scsi_set_medium_removal
sr_lock_door
cdrom_release
...
umount

I tried adding a 

	if (!sdev) 
		return BLKPREP_KILL;

to scsi_prep_state_check, but that caused a RCU CPU stall 
and a generally unhappy system instead.

The sdev must be still there in scsi_set_medium_removal because it's 
referenced, so it must get lost somewhere in SCSI or in the block layer.

Any ideas how to fix this?

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only

             reply	other threads:[~2011-07-01 17:06 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01 17:05 Andi Kleen [this message]
2011-07-01 18:14 ` Linux 3.0 oopses when pulling a USB CDROM Dave Jones
2011-07-01 18:32   ` Andi Kleen
2011-07-01 18:40     ` Dave Jones
2011-07-02 15:13     ` Christoph Fritz
2011-07-01 20:29   ` James Bottomley
2011-07-01 20:43     ` [PATCH] USB: fix regression occurring during device removal Alan Stern
2011-07-01 20:43       ` Alan Stern
2011-07-01 21:04       ` Andi Kleen
2011-07-01 21:04     ` Linux 3.0 oopses when pulling a USB CDROM Alan Stern
2011-07-01 21:04       ` Alan Stern
2011-07-01 21:13       ` James Bottomley
2011-07-02  2:03         ` Alan Stern
2011-07-02  2:03           ` Alan Stern
2011-07-02  6:08           ` Andi Kleen
2011-07-02 12:24             ` James Bottomley
2011-07-02 17:05               ` Andi Kleen
2011-07-02 17:09                 ` James Bottomley
2011-07-02 17:09                   ` James Bottomley
2011-07-02 18:15                   ` Andi Kleen
2011-07-02 18:15                     ` Andi Kleen
2011-07-02 20:05                     ` Alan Stern
2011-07-02 20:05                       ` Alan Stern
2011-07-03  1:16                       ` Andi Kleen
2011-07-03  1:16                         ` Andi Kleen
2011-07-03 15:29                         ` Alan Stern
2011-07-03 15:29                           ` Alan Stern
2011-07-03 16:06                           ` Alan Stern
2011-07-03 16:06                             ` Alan Stern
2011-07-02 17:37               ` Alan Stern
2011-07-02 17:37                 ` Alan Stern
2011-07-02 18:11                 ` Andi Kleen
2011-07-02 19:59                   ` Alan Stern
2011-07-03  1:17                     ` Andi Kleen
2011-07-07 20:47                     ` solved was " Andi Kleen
2011-07-18 16:59                     ` Dan Williams
2011-07-18 18:00                       ` Andi Kleen
2011-07-20  9:58                       ` Jack Wang
2011-07-20  9:58                         ` Jack Wang
2011-10-18 21:16                         ` Ankit Jain
2011-10-18 21:30                           ` James Bottomley
2011-10-21 13:26                             ` Hannes Reinecke
2011-07-03  9:14                 ` Dan Williams
2011-07-03 18:16                   ` Andi Kleen
2011-07-03 20:37                 ` Stefan Richter
2011-07-08 13:37                   ` Stefan Richter
2011-07-08 13:41                     ` Stefan Richter
2011-07-08 13:41                       ` Stefan Richter
2011-07-04 11:27                 ` Heiko Carstens
2011-07-04 11:27                   ` Heiko Carstens
2011-07-04 16:04                   ` Alan Stern
2011-07-06  6:50                     ` Heiko Carstens
2011-07-12 18:49                     ` Jonathan McDowell
2011-07-02 12:38             ` Alan Stern
2011-07-02 12:38               ` Alan Stern
2011-07-02 18:10               ` Andi Kleen
2011-07-02 18:10                 ` Andi Kleen
2011-07-02 12:48             ` Rafael J. Wysocki
2011-07-02 12:48               ` Rafael J. Wysocki
2011-07-02 17:06               ` Andi Kleen
2011-07-01 19:20 ` James Bottomley
2011-07-01 19:33   ` James Bottomley
2011-07-01 19:45     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110701170531.GA3693@tassilo.jf.intel.com \
    --to=andi@firstfloor.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.