All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, sodaville@linutronix.de
Subject: Re: [PATCH v2 2/2] gpio: Add a driver for Sodaville GPIO controller
Date: Mon, 4 Jul 2011 10:33:13 -0600	[thread overview]
Message-ID: <20110704163313.GB28042@ponder.secretlab.ca> (raw)
In-Reply-To: <4E11EA63.8010909@linutronix.de>

On Mon, Jul 04, 2011 at 06:29:23PM +0200, Sebastian Andrzej Siewior wrote:
> Grant Likely wrote:
> >
> >I tried to apply this, but it failed to build:
> >
> >/home/grant/hacking/linux-2.6/drivers/gpio/gpio-sodaville.c: In
> >function ‘sdv_xlate’:
> >/home/grant/hacking/linux-2.6/drivers/gpio/gpio-sodaville.c:106:15:
> >error: ‘struct irq_domain’ has no member named ‘of_node’
> 
> >I assume there is a missing #include, you can either send a fixup
> >patch or a new version, your choice.
> 
> I guess you have to ask the DT maintainer which merged the irq_domain
> thingy to create a topic branch for you :)

HAHAHA.  I didn't bother to go digging into why it didn't compile.
I'll merge the branches and see how it goes.

> 
> >Also...
> >
> >>diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> >>index 0fbdd75..cc6d662 100644
> >>--- a/drivers/gpio/Makefile
> >>+++ b/drivers/gpio/Makefile
> >>@@ -41,6 +41,7 @@ obj-$(CONFIG_GPIO_S5PV210)	+= gpio-s5pv210.o
> >> obj-$(CONFIG_GPIO_SCH)		+= gpio-sch.o
> >> obj-$(CONFIG_GPIO_STMPE)	+= gpio-stmpe.o
> >>+obj-$(CONFIG_GPIO_SODAVILLE)	+= gpio-sodaville.o
> >> obj-$(CONFIG_GPIO_SX150X)	+= gpio-sx150x.o
> >> obj-$(CONFIG_GPIO_TC3589X)	+= gpio-tc3589x.o
> >> obj-$(CONFIG_ARCH_TEGRA)	+= gpio-tegra.o
> >
> >Last I checked, SO comes before ST in alphabetized lists.  :-)
> 
> Ah, we use the standardized one. Is it okay to send an incremental patch
> for that once it compiles?

Don't worry about it.  I've already fixed it up.

g.


  reply	other threads:[~2011-07-04 16:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27  7:26 [PATCH 1/2] gpio/gpio-generic: read set register for caching if available Sebastian Andrzej Siewior
2011-06-27  7:26 ` [PATCH v2 2/2] gpio: Add a driver for Sodaville GPIO controller Sebastian Andrzej Siewior
2011-06-27  9:33   ` Alan Cox
2011-06-27 10:34     ` Sebastian Andrzej Siewior
2011-07-04  7:26   ` [sodaville] " Sebastian Andrzej Siewior
2011-07-04 16:19   ` Grant Likely
2011-07-04 16:29     ` Sebastian Andrzej Siewior
2011-07-04 16:33       ` Grant Likely [this message]
2011-07-04 16:35         ` Grant Likely
2011-08-01 16:44           ` [sodaville] " Sebastian Andrzej Siewior
2011-07-04 15:44 ` [PATCH 1/2] gpio/gpio-generic: read set register for caching if available Grant Likely
2011-07-04 15:57   ` Sebastian Andrzej Siewior
2011-07-20  7:24   ` [PATCH 1/2 v2] gpio/gpio-generic: read correct " Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110704163313.GB28042@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sodaville@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.