From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: MyungJoo Ham <myungjoo.ham@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Donggeun Kim <dg77.kim@samsung.com>
Subject: Re: [PATCH 3/3] MFD: MAX8997: IRQ definition moved to public header.
Date: Mon, 4 Jul 2011 10:16:37 -0700 [thread overview]
Message-ID: <20110704171634.GD28726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTikPOj6N=TQ=tayx7hTXcLAJd5zf7w@mail.gmail.com>
On Fri, Jul 01, 2011 at 09:43:31AM +0900, MyungJoo Ham wrote:
> On Fri, Jul 1, 2011 at 12:56 AM, Mark Brown
> > This looks like charger specific configuration which should be done by
> > the charger driver rather than by directly working with the IRQs?
> Well, the issue is that the charger driver just does not know what to
> do with its own interrupts.
> For example, each board has different regulator setting for DCIN
> depending on the specification of the board (some uses 450mA
> constantly, some uses 450mA and 700mA depending on the connection
> information, which is not known to charger driver, some uses 900mA
> unconditionally, and so on).
That sounds like the charger driver just needs some platform data.
> Sometimes setting the attributes of a charger at its own interrupts
> depends on the status of another charger; when we have USB charger,
> wireless charger, and solar panels, which may be enabled independently
> and have their own device drivers.
My understanding was that one of the goals of the power_supply subsystem
was to support this sort of interaction? This (and your subsequent
paragraphs) all sounds entirely sensible but it should be being dealt
with at a higher level with the various charger drivers delivering
events into a subsystem or board driver which coordinates them all. It
seems like the driver should be doing the work of dealing with the
actual interrupts.
next prev parent reply other threads:[~2011-07-04 17:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 1:31 [PATCH 1/3] MFD: MAX8997: IRQ Handling Bugfix MyungJoo Ham
2011-06-30 1:31 ` [PATCH 2/3] MFD: MAX8997: Support Wake-up from Suspend MyungJoo Ham
2011-06-30 1:31 ` [PATCH 3/3] MFD: MAX8997: IRQ definition moved to public header MyungJoo Ham
2011-06-30 5:28 ` Mark Brown
2011-06-30 5:56 ` MyungJoo Ham
2011-06-30 5:57 ` Mark Brown
2011-06-30 8:00 ` MyungJoo Ham
2011-06-30 15:56 ` Mark Brown
2011-07-01 0:43 ` MyungJoo Ham
2011-07-04 17:16 ` Mark Brown [this message]
2011-07-05 5:57 ` MyungJoo Ham
2011-07-05 6:19 ` Mark Brown
2011-07-05 6:49 ` MyungJoo Ham
2011-07-05 19:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704171634.GD28726@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dg77.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=myungjoo.ham@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.