All of lore.kernel.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: Unnecessary cache-line flush on page table updates ?
Date: Wed, 6 Jul 2011 17:15:42 +0100	[thread overview]
Message-ID: <20110706161542.GI32020@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <20110706155525.GH8286@n2100.arm.linux.org.uk>

On Wed, Jul 06, 2011 at 04:55:25PM +0100, Russell King - ARM Linux wrote:
> On Wed, Jul 06, 2011 at 04:52:14PM +0100, Catalin Marinas wrote:
> > On Tue, Jul 05, 2011 at 10:46:52AM +0100, Russell King - ARM Linux wrote:
> > > I've since added the dsb+isbs back to the TLB ops because the ARM ARM
> > > is qutie explicit that both are required to ensure that explicit
> > > accesses see the effect of the TLB operation.  To me it is rather
> > > perverse that an ISB is required to ensure that this sequence works:
> > > 
> > > 	write page table entry
> > > 	clean
> > > 	dsb
> > > 	flush tlb entry
> > > 	dsb
> > > 	isb
> > > 	read/write new page
> > 
> > The same requirement can be found in latest (internal only) ARM ARM as
> > well. I think the reason is that some memory access already in the
> > pipeline (but after the TLB flush) may have sampled the state of the
> > page table using an old TLB entry, even though the actual memory access
> > will happen after the DSB.
> 
> It would be useful to have a statement from RG on this.  Could you
> pass this to him please?

Just checked - it is required as per the ARM ARM and there are cores
that rely on the ISB. As I said, it depends on the pipeline
implementation.

-- 
Catalin

  reply	other threads:[~2011-07-06 16:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01  7:04 Unnecessary cache-line flush on page table updates ? heechul Yun
2011-07-01 10:10 ` Catalin Marinas
2011-07-01 21:42   ` heechul Yun
2011-07-04  9:45     ` Catalin Marinas
2011-07-04 10:02       ` Russell King - ARM Linux
2011-07-04 10:43         ` Catalin Marinas
2011-07-04 11:13           ` Russell King - ARM Linux
2011-07-04 15:58             ` Catalin Marinas
2011-07-04 19:58               ` Russell King - ARM Linux
2011-07-04 23:20                 ` Russell King - ARM Linux
2011-07-06 16:05                   ` Catalin Marinas
2011-07-06 18:08                     ` Russell King - ARM Linux
2011-07-11 16:49                       ` Catalin Marinas
2011-07-11 17:01                         ` Russell King - ARM Linux
2011-07-12 13:09                           ` Catalin Marinas
2011-07-15 16:24                             ` Russell King - ARM Linux
2011-07-05 10:07                 ` Catalin Marinas
2011-07-04 21:55             ` Russell King - ARM Linux
2011-07-05  9:26               ` Catalin Marinas
2011-07-05  9:46                 ` Russell King - ARM Linux
2011-07-06 15:52                   ` Catalin Marinas
2011-07-06 15:55                     ` Russell King - ARM Linux
2011-07-06 16:15                       ` Catalin Marinas [this message]
2011-07-05 10:48                 ` Russell King - ARM Linux
2011-07-05 13:54                   ` Catalin Marinas
2011-07-05 14:15                     ` Russell King - ARM Linux
2011-07-05 14:40                       ` Catalin Marinas
2011-07-04 13:05           ` Russell King - ARM Linux
2011-07-04 13:15             ` Catalin Marinas
2011-07-04 14:59       ` heechul Yun
2011-07-04 21:24     ` heechul Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110706161542.GI32020@e102109-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.