From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756014Ab1GFUIM (ORCPT ); Wed, 6 Jul 2011 16:08:12 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:41053 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755529Ab1GFUIK (ORCPT ); Wed, 6 Jul 2011 16:08:10 -0400 Date: Wed, 6 Jul 2011 21:06:07 +0100 From: Russell King - ARM Linux To: Simon Glass Cc: Olof Johansson , Stephen Boyd , anish singh , lak , Tony Lindgren , Nicolas Pitre , Catalin Marinas , Joe Perches , Laurent Pinchart , Alexander Shishkin , Phil Carmody , Rabin Vincent , lk , Omar Ramirez Luna , Dave Martin Subject: Re: [PATCH v4] ARM: Use generic BUG() handler Message-ID: <20110706200607.GS8286@n2100.arm.linux.org.uk> References: <1302822031-6752-1-git-send-email-sjg@chromium.org> <4DA7A914.5020804@codeaurora.org> <143ea9b1bb96e613d534caa7cb3a1e2d.squirrel@www.codeaurora.org> <20110426014741.GB28721@quad.lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2011 at 10:24:31PM -0700, Simon Glass wrote: > On Mon, Apr 25, 2011 at 6:47 PM, Olof Johansson wrote: > > On Wed, Apr 20, 2011 at 11:01:59AM -0700, Stephen Boyd wrote: > > > >> It's here: > >> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6885/1 > >> > >> I imagine it will be added when/if Russell picks it up. Sadly it > >> increases the LOC in ARM so Simon might need to really > >> sell it to get it merged. > > > > It's core code though, and the concern today is not with ARM core code > > as much as with the various platforms that are growing seemingly without > > upper bounds. > > Hi, > > Can anyone advise please what happens next with this patch? So far I > have posted it to the list, it has been reviewed on the list and I > have put it into the patch system. What is the next step please to get > this into the kernel? Sorry, I've finally got back to looking at this. + ".pushsection .rodata.str, \"aMS\", 1\n" \ According to my gas manual: | 7.88 `.pushsection NAME [, SUBSECTION] [, "FLAGS"[, @TYPE[,ARGUMENTS]]]' | ... | This directive pushes the current section (and subsection) onto the | top of the section stack, and then replaces the current section and | subsection with `name' and `subsection'. The optional `flags', `type' | and `arguments' are treated the same as in the `.section' (*note | Section::) directive. | | 7.94 `.section NAME' | ... | ELF Version | ... | Note on targets where the `@' character is the start of a comment (eg | ARM) then another character is used instead. For example the ARM port | uses the `%' character. | | If FLAGS contains the `M' symbol then the TYPE argument must be | specified as well as an extra argument--ENTSIZE--like this: | | .section NAME , "FLAGS"M, @TYPE, ENTSIZE | | Sections with the `M' flag but not `S' flag must contain fixed size | constants, each ENTSIZE octets long. Sections with both `M' and `S' | must contain zero terminated strings where each character is ENTSIZE | bytes long. The linker may remove duplicates within sections with the | same name, same entity size and same flags. ENTSIZE must be an | absolute expression. It appears that the TYPE argument is missing. As the GAS manual says its required, then I think it really ought to be there. Any comment? From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Wed, 6 Jul 2011 21:06:07 +0100 Subject: [PATCH v4] ARM: Use generic BUG() handler In-Reply-To: References: <1302822031-6752-1-git-send-email-sjg@chromium.org> <4DA7A914.5020804@codeaurora.org> <143ea9b1bb96e613d534caa7cb3a1e2d.squirrel@www.codeaurora.org> <20110426014741.GB28721@quad.lixom.net> Message-ID: <20110706200607.GS8286@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 19, 2011 at 10:24:31PM -0700, Simon Glass wrote: > On Mon, Apr 25, 2011 at 6:47 PM, Olof Johansson wrote: > > On Wed, Apr 20, 2011 at 11:01:59AM -0700, Stephen Boyd wrote: > > > >> It's here: > >> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6885/1 > >> > >> I imagine it will be added when/if Russell picks it up. Sadly it > >> increases the LOC in ARM so Simon might need to really > >> sell it to get it merged. > > > > It's core code though, and the concern today is not with ARM core code > > as much as with the various platforms that are growing seemingly without > > upper bounds. > > Hi, > > Can anyone advise please what happens next with this patch? So far I > have posted it to the list, it has been reviewed on the list and I > have put it into the patch system. What is the next step please to get > this into the kernel? Sorry, I've finally got back to looking at this. + ".pushsection .rodata.str, \"aMS\", 1\n" \ According to my gas manual: | 7.88 `.pushsection NAME [, SUBSECTION] [, "FLAGS"[, @TYPE[,ARGUMENTS]]]' | ... | This directive pushes the current section (and subsection) onto the | top of the section stack, and then replaces the current section and | subsection with `name' and `subsection'. The optional `flags', `type' | and `arguments' are treated the same as in the `.section' (*note | Section::) directive. | | 7.94 `.section NAME' | ... | ELF Version | ... | Note on targets where the `@' character is the start of a comment (eg | ARM) then another character is used instead. For example the ARM port | uses the `%' character. | | If FLAGS contains the `M' symbol then the TYPE argument must be | specified as well as an extra argument--ENTSIZE--like this: | | .section NAME , "FLAGS"M, @TYPE, ENTSIZE | | Sections with the `M' flag but not `S' flag must contain fixed size | constants, each ENTSIZE octets long. Sections with both `M' and `S' | must contain zero terminated strings where each character is ENTSIZE | bytes long. The linker may remove duplicates within sections with the | same name, same entity size and same flags. ENTSIZE must be an | absolute expression. It appears that the TYPE argument is missing. As the GAS manual says its required, then I think it really ought to be there. Any comment?