All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: David Sharp <dhsharp@google.com>,
	Vaibhav Nagarnaik <vnagarnaik@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Michael Rubin <mrubin@google.com>,
	x86@kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jiaying Zhang <jiayingz@google.com>
Subject: Re: [PATCH v2] trace: Add x86 irq vector entry/exit tracepoints
Date: Thu, 7 Jul 2011 02:25:15 +0200	[thread overview]
Message-ID: <20110707002512.GB21115@somewhere> (raw)
In-Reply-To: <4E14F797.8070501@zytor.com>

On Wed, Jul 06, 2011 at 05:02:31PM -0700, H. Peter Anvin wrote:
> On 07/06/2011 04:56 PM, Frederic Weisbecker wrote:
> > And even if tracepoints are not supposed to be stable ABI (I actually believe there
> > is no absolute answer to that, it depends on the tracepoint and on the context),
> > tools are much happier with a common tracepoint interface amongst archs.
> 
> What you're suggesting here is an ad hoc ABI.  This is insanely
> irresponsible -- ABIs need to be designed, not randomly appeared.

I'm suggesting two things:

1) If every arch implement a tracepoint for a generic event, then move the tracepoint
to the generic code. I believe that part is not very controversial.

2) If every arch implement a common event that is not implemented in core code (I believe
it was the case for reschedule_interrupt few times ago but changed lately) then try
to have a common tracepoint for every archs if possible. So that we don't have
thousand names for the same event, or different parameters name when those parameters and the
event semantic are exactly the same amongst every architecture.

Trace events are irresponsible anyway because they involve that "ABI not really stable but tools
rely on it so...well...)". I'm not sure the above points make the situation worse though. Probably
the cases that fit in 2) need to be carefully checked to ensure they really fit in 2).

Having each archs proposing their own wild tracepoints is not going to cure the fundamental
nature of trace events. An arch that implements its own tracepoint already applies a new ad-hoc
ABI. Its scope is just smaller.

  reply	other threads:[~2011-07-07  0:25 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 22:56 [PATCH] trace: Add special x86 irq entry/exit tracepoints Vaibhav Nagarnaik
2011-04-25 23:41 ` Vaibhav Nagarnaik
2011-04-28 23:16   ` Vaibhav Nagarnaik
2011-04-28 23:41   ` Steven Rostedt
2011-04-29 20:12   ` [PATCH] trace: Add x86 irq vector " Vaibhav Nagarnaik
2011-04-29 20:26     ` Thomas Gleixner
2011-04-29 22:04       ` Vaibhav Nagarnaik
2011-05-31 21:28     ` [PATCH v2] " Vaibhav Nagarnaik
2011-06-01  0:00       ` Frederic Weisbecker
2011-06-01 22:38         ` Vaibhav Nagarnaik
2011-06-01 23:30           ` David Sharp
2011-06-16  3:02             ` Frederic Weisbecker
2011-06-21 18:43               ` Vaibhav Nagarnaik
2011-07-06 23:43               ` H. Peter Anvin
2011-07-06 23:56                 ` Frederic Weisbecker
2011-07-07  0:02                   ` H. Peter Anvin
2011-07-07  0:25                     ` Frederic Weisbecker [this message]
2011-07-07  0:30                       ` H. Peter Anvin
2011-07-07  0:51                         ` Frederic Weisbecker
2011-07-07  9:57                         ` Ingo Molnar
2011-07-07 22:50                           ` David Sharp
2011-07-07 23:00                             ` Frederic Weisbecker
2011-06-21 18:45       ` [PATCH v3] " Vaibhav Nagarnaik
2011-07-06 21:50         ` Vaibhav Nagarnaik
2011-07-06 23:38           ` Andi Kleen
2011-07-07 23:34         ` Frederic Weisbecker
2011-07-08  0:54           ` David Sharp
2011-07-11 15:54             ` Frederic Weisbecker
2011-07-11 18:21               ` Vaibhav Nagarnaik
2011-07-12 18:09                 ` Frederic Weisbecker
2011-07-12 22:08                   ` Vaibhav Nagarnaik
2011-07-13 14:11                     ` Frederic Weisbecker
2011-07-13 18:18                       ` Vaibhav Nagarnaik
2011-04-29  0:14 ` [PATCH] trace: Add special x86 irq " Thomas Gleixner
2011-04-29 20:15   ` Vaibhav Nagarnaik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110707002512.GB21115@somewhere \
    --to=fweisbec@gmail.com \
    --cc=dhsharp@google.com \
    --cc=hpa@zytor.com \
    --cc=jiayingz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mrubin@google.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=vnagarnaik@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.