From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Fri, 08 Jul 2011 15:04:54 +0200
Subject: [U-Boot] [RFC PATCH 3/4] Add new folder and build system for SPL
In-Reply-To: <4E16FD50.3090005@ti.com>
References: <1309352967-5719-1-git-send-email-aneesh@ti.com>
	<1309883182-12854-1-git-send-email-daniel.schwierzeck@googlemail.com>
	<1309883182-12854-4-git-send-email-daniel.schwierzeck@googlemail.com>
	<20110708091721.79CCB126F38F@gemini.denx.de>
	<4E16EAE9.5070505@ti.com>
	<20110708123233.31C6B15794A4@gemini.denx.de>
	<4E16FD50.3090005@ti.com>
Message-ID: <20110708130454.99AF3126F38F@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Aneesh V,

In message <4E16FD50.3090005@ti.com> you wrote:
>
> > - use a different name instead of OBJTREE everywhere, and leave
> 
> What Daniel suggested about using something like SPLTREE(or SPLOBJTREE)
> seems to be be right solution then. Are you ok with that?

Yes, if it works without too much effort.

> > - introduce a new variable that stores the original setting of OBJTREE
> >    so we can refer to this later
> >
> >> I used BUILD_DIR/spl/obj as OBJTREE to avoid this problem.

Well, this may cause nasty problems.  Note that BUILD_DIR is usually
not set for local builds; current Makefile looks like this:

OBJTREE         := $(if $(BUILD_DIR),$(BUILD_DIR),$(CURDIR))
SRCTREE         := $(CURDIR)
TOPDIR          := $(SRCTREE)
...
ifneq ($(OBJTREE),$(SRCTREE))
...

Tests like this here will fail if you use BUILD_DIR (which is not set)
instead of OBJTREE (which is set to CURDIR).

> You want to continue to maintain nand_boot.c kind of files within
> $(TOPDIR)/spl/ , right?

Yes.  Copies of, or symlinks to, source files should be avoided.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you're not part of the solution, you're part of the problem.