All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: markpearson_de@yahoo.de
Cc: abbotti@mev.co.uk, fmhess@users.sourceforge.net,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: Fixing style issues
Date: Sun, 10 Jul 2011 11:26:34 -0700	[thread overview]
Message-ID: <20110710182634.GA19612@kroah.com> (raw)
In-Reply-To: <1310321566-29266-1-git-send-email-markpearson_de@yahoo.de>

On Sun, Jul 10, 2011 at 08:12:46PM +0200, markpearson_de@yahoo.de wrote:
> From: Mark Pearson <markpearson_de@yahoo.de>
> 
> comedi_fops.c : Warning that externs should be avoided in .c files.
>                 A forward function decleration was declared extern
>                 although it was only used internally. Changed
>                 decleration to static.
> comedi.h      : Fixed warning that storage class should be a the
>                 begining of declerations.
> 
> Lindent ran on both files.
> 
> Ignore previous patch - forgot to add signed off by.

Care to break this up into a set of "only do one thing per patch"
series?  That way it's reviewable.

Also, running Lindent is usually a very bad idea on files that have been
around for a while now.  It causes a lot of unneeded churn, please just
make the minor changes needed to be checkpatch.pl clean by hand.

thanks,

greg k-h

  reply	other threads:[~2011-07-10 18:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-10 18:12 [PATCH] Staging: comedi: Fixing style issues markpearson_de
2011-07-10 18:26 ` Greg KH [this message]
2011-07-10 19:22   ` AW: " Mark Pearson
  -- strict thread matches above, loose matches on Subject: below --
2011-07-10 17:02 markpearson_de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110710182634.GA19612@kroah.com \
    --to=greg@kroah.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markpearson_de@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.