Re: [PATCH BlueZ v3] Fix unpair device when disconnected for No Bonding

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Dmitriy,

On Mon, Jul 11, 2011, Dmitriy Paliy wrote:
> Fix Paired device property if 'No Bonding' authentication is used. It is
> set to be false when device is disconnected and no link key is stored.
> Otherwise, there can be cases when device is still valid and being
> claimed as paired without available bonding information.
> 
> For instanse, use of CreateDevice method call and obex client file
> transfer is such use case.
> ---
>  src/device.c |   19 ++++++++++++++++++-
>  src/device.h |    1 +
>  src/event.c  |    8 ++++++--
>  3 files changed, 25 insertions(+), 3 deletions(-)

Applied, and I also pushed a cleanup patch on top of it because
device_remove_bonding was essentially useless. One thing that I'm
thinking of is maybe it'd be better to get rid of the paired and bonded
booleans have a single enum for them since they are dependent on each
other and one combination of boolean values (!paired && bonded) is not
possible. Maybe something like the following inside struct btd_device:

	enum {
		DEVICE_PAIRING_STATUS_NONE,
		DEVICE_PAIRING_STATUS_PAIRED,
		DEVICE_PAIRING_STATUS_BONDED,
	} pairing_status;

Thoughts?

Johan