From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:34851 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758342Ab1GKSq6 (ORCPT ); Mon, 11 Jul 2011 14:46:58 -0400 Date: Mon, 11 Jul 2011 14:35:51 -0400 From: "John W. Linville" To: Joe Perches Cc: Wey-Yi Guy , Intel Linux Wireless , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] iwlagn: Add missing comma between constant string array Message-ID: <20110711183550.GC2650@tuxdriver.com> (sfid-20110711_204724_362813_E61F19F2) References: <2c8a6e15b0f320e4b4b761ae6434862fc3c15924.1310187270.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <2c8a6e15b0f320e4b4b761ae6434862fc3c15924.1310187270.git.joe@perches.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: How is this array indexed? Aren't you changing the index of the later strings? On Fri, Jul 08, 2011 at 11:20:25PM -0700, Joe Perches wrote: > Multiple quoted strings are concatenated without comma separators. > > Make the array const while there. > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/iwlwifi/iwl-agn.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c > index 7e6c463..de1a0c1 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-agn.c > +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c > @@ -1563,7 +1563,7 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context) > release_firmware(ucode_raw); > } > > -static const char *desc_lookup_text[] = { > +static const char * const desc_lookup_text[] = { > "OK", > "FAIL", > "BAD_PARAM", > @@ -1587,7 +1587,7 @@ static const char *desc_lookup_text[] = { > "NMI_INTERRUPT_DATA_ACTION_PT", > "NMI_TRM_HW_ER", > "NMI_INTERRUPT_TRM", > - "NMI_INTERRUPT_BREAK_POINT" > + "NMI_INTERRUPT_BREAK_POINT", > "DEBUG_0", > "DEBUG_1", > "DEBUG_2", > -- > 1.7.6.131.g99019 > > -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.