From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qgva6-0000He-Eh for qemu-devel@nongnu.org; Wed, 13 Jul 2011 05:18:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qgva3-00022T-TL for qemu-devel@nongnu.org; Wed, 13 Jul 2011 05:18:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qgva2-00022E-Rr for qemu-devel@nongnu.org; Wed, 13 Jul 2011 05:18:07 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6D9I5ZR015525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Jul 2011 05:18:05 -0400 Date: Wed, 13 Jul 2011 12:17:42 +0300 From: Alon Levy Message-ID: <20110713091742.GE28430@bow.tlv.redhat.com> References: <1310478932-25370-1-git-send-email-alevy@redhat.com> <1310478932-25370-18-git-send-email-alevy@redhat.com> <4E1D4F4F.9090500@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E1D4F4F.9090500@redhat.com> Subject: Re: [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Wed, Jul 13, 2011 at 09:54:55AM +0200, Gerd Hoffmann wrote: > Hi, > > >The "solution" of ignoring the request is bad, but better then aborting > >and a real solution would probably be in spice to not call get_command > >in the first place. > > Isn't the plan to fix spice-server this way? I can't reproduce this right now, I'll drop the patch. I do see spice-server is fixed in red_process_commands to not call get_command on stopped, so I probably used an unpatched server when this happened. > > cheers, > Gerd >