From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22765 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965134Ab1GMJZp (ORCPT ); Wed, 13 Jul 2011 05:25:45 -0400 Date: Wed, 13 Jul 2011 11:25:38 +0200 From: Stanislaw Gruszka To: "John W. Linville" Cc: Joe Perches , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] iwlegacy: Add missing comma between constant string array Message-ID: <20110713092538.GA2429@redhat.com> (sfid-20110713_112618_834557_3CDF0F12) References: <36f8b5d1a32b8702941ebeda7a406188af132e9e.1310187270.git.joe@perches.com> <20110711183542.GB2650@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110711183542.GB2650@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jul 11, 2011 at 02:35:42PM -0400, John W. Linville wrote: > How is this array indexed? Aren't you changing the index of the > later strings? We read index directly from device memory (and check agains ARRAY_SIZE). Patch make indexing correct with code author intention, ACK. iwlagn should be simmilarly fine. Stanislaw > On Fri, Jul 08, 2011 at 11:20:24PM -0700, Joe Perches wrote: > > Multiple quoted strings are concatenated without comma separators. > > > > Signed-off-by: Joe Perches > > --- > > drivers/net/wireless/iwlegacy/iwl4965-base.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/net/wireless/iwlegacy/iwl4965-base.c b/drivers/net/wireless/iwlegacy/iwl4965-base.c > > index 46242d2..1433466 100644 > > --- a/drivers/net/wireless/iwlegacy/iwl4965-base.c > > +++ b/drivers/net/wireless/iwlegacy/iwl4965-base.c > > @@ -1484,7 +1484,7 @@ static const char * const desc_lookup_text[] = { > > "NMI_INTERRUPT_DATA_ACTION_PT", > > "NMI_TRM_HW_ER", > > "NMI_INTERRUPT_TRM", > > - "NMI_INTERRUPT_BREAK_POINT" > > + "NMI_INTERRUPT_BREAK_POINT", > > "DEBUG_0", > > "DEBUG_1", > > "DEBUG_2", > > -- > > 1.7.6.131.g99019 > > > > > > -- > John W. Linville Someday the world will need a hero, and you > linville@tuxdriver.com might be all we have. Be ready. > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html