From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46511)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QgvmD-0002mE-Vc
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 05:30:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QgvmB-0003zl-Su
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 05:30:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57436)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QgvmB-0003zf-CM
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 05:30:39 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6D9UbB0005101
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2011 05:30:38 -0400
Date: Wed, 13 Jul 2011 12:30:15 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110713093015.GH28430@bow.tlv.redhat.com>
References: <1310478932-25370-1-git-send-email-alevy@redhat.com>
	<1310478932-25370-17-git-send-email-alevy@redhat.com>
	<4E1D4E72.3080300@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E1D4E72.3080300@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and
 update_area_complete
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Jul 13, 2011 at 09:51:14AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >+void qxl_render_primary_updated(PCIQXLDevice *qxl, QXLRect *dirty,
> >+                                uint32_t num_dirty);
> 
> >@@ -65,6 +65,10 @@ struct SimpleSpiceDisplay {
> >      int notify;
> >      int running;
> >
> >+#if SPICE_INTERFACE_QXL_MINOR>= 1
> >+    QXLRect *dirty_rects;
> >+    uint32_t num_dirty_rects;
> >+#endif
> 
> Why do you put this into SimpleSpiceDisplay instead of PCIQXLState?
> 
> I also wouldn't #ifdef the struct elements to reduce the #ifdef
> clutter.  #ifdefs should only be there in case the code wouldn't
> compile without them.
> 
> Additionally you can fill these struct elements in sync mode too and
> have qxl_render_primary_updated pick up the rectangles from the
> struct instead of getting them passed in as arguments, thereby
> reducing the code differences between sync and async mode.
> 

ok, will do.

> cheers,
>   Gerd
>