From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47247)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QgyiX-0001vf-5x
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 08:39:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QgyiV-0003O0-GG
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 08:39:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18741)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QgyiU-0003Nu-VO
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 08:39:03 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6DCd1u7018551
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2011 08:39:02 -0400
Date: Wed, 13 Jul 2011 09:39:00 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110713093900.7a9c3dfc@doriath>
In-Reply-To: <4E1D85AA.7050106@redhat.com>
References: <1310478932-25370-1-git-send-email-alevy@redhat.com>
	<1310478932-25370-14-git-send-email-alevy@redhat.com>
	<4E1D44DB.5090803@redhat.com>
	<20110713092909.GF28430@bow.tlv.redhat.com>
	<4E1D766C.1090308@redhat.com>
	<20110713112916.GL28430@bow.tlv.redhat.com>
	<4E1D85AA.7050106@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, 13 Jul 2011 13:46:50 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

>    Hi,
> 
> > I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's becoming pretty
> > ugly. Also I guess what Daniel described is possible, but it changes the usage of screendump
> > even more. Is turning do_screen_dump to async viable? I think I'll work on it.
> 
> Daniel's suggestion is a nice option which goes on top ;)

Some months ago it was suggested that we returned the screenshot as a base64
string. But this might have issues if the screenshot is/becomes too large,
as we're imposing some limits on the json token size (I think it's 64MB today).

Daniel's idea seems to be a good one though.

> 
> The filename-based screendump has to continue working for backward 
> compatibility reasons.
> 
> cheers,
>    Gerd
>