From: Luiz Capitulino <lcapitulino@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm
Date: Wed, 13 Jul 2011 10:15:04 -0300 [thread overview]
Message-ID: <20110713101504.66fc9a16@doriath> (raw)
In-Reply-To: <20110713125655.GM28430@bow.tlv.redhat.com>
On Wed, 13 Jul 2011 15:56:55 +0300
Alon Levy <alevy@redhat.com> wrote:
> On Wed, Jul 13, 2011 at 09:33:26AM -0300, Luiz Capitulino wrote:
> > On Wed, 13 Jul 2011 14:29:16 +0300
> > Alon Levy <alevy@redhat.com> wrote:
> >
> > > On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote:
> > > > On 07/13/11 11:29, Alon Levy wrote:
> > > > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote:
> > > > >>On 07/12/11 15:55, Alon Levy wrote:
> > > > >>>Later the save will happen asynchronously on surface_updated callback.
> > > > >>
> > > > >>Hmm. I can see why you are doing that. It makes the file being
> > > > >>written *after* the monitor command finishes though, which I think
> > > > >>we should avoid.
> > > > >
> > > > >I think the simplest thing would be to add a specific cond for this - ppm_save_filename_cond. ok?
> > > >
> > > > Not sure. Luiz, do we have async monitor commands meanwhile?
> > > >
> > > > Background: screendump for qxl vga can take a while as the
> > > > spice-server might have to render everything first ...
> > >
> > > I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's becoming pretty
> > > ugly.
> >
> > IIRC, that interface doesn't work as expected and is going to be replaced
> > by the QAPI's one.
>
> In what way is in wrong? it seems to work fine here - monitor is blocked until
> I call the callback, after which it returns. Didn't test the qmp part though.
One problem is that the error is global and could be overwritten by other
handlers. Another problem is that there's no way for a client to kill an async
handler that got stuck, this could cause a client to wait for the handler
forever.
>
> >
> > > Also I guess what Daniel described is possible, but it changes the usage of screendump
> > > even more. Is turning do_screen_dump to async viable? I think I'll work on it.
> > >
> > > >
> > > > cheers,
> > > > Gerd
> > > >
> > >
> >
>
next prev parent reply other threads:[~2011-07-13 13:15 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 13:55 [Qemu-devel] [PATCHv3] async + suspend reworked Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] spice: add worker wrapper functions Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] spice: add qemu_spice_display_init_common Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: remove qxl_destroy_primary() Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] spice/qxl: move worker wrappers Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: fix surface tracking & locking Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: add io_port_to_string Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: error handling fixes and cleanups Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: make qxl_guest_bug take variable arguments Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: bump pci rev Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: use QXL_REVISION_* Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: QXL_IO_UPDATE_AREA: pass ram->update_area directly to update_area Alon Levy
2011-07-13 6:56 ` Gerd Hoffmann
2011-07-13 9:29 ` Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: async io support using new spice api Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm Alon Levy
2011-07-13 7:10 ` Gerd Hoffmann
2011-07-13 9:29 ` Alon Levy
2011-07-13 10:41 ` Gerd Hoffmann
2011-07-13 10:54 ` Daniel P. Berrange
2011-07-13 11:29 ` Alon Levy
2011-07-13 11:46 ` Gerd Hoffmann
2011-07-13 12:39 ` Luiz Capitulino
2011-07-13 12:33 ` Luiz Capitulino
2011-07-13 12:56 ` Alon Levy
2011-07-13 13:15 ` Luiz Capitulino [this message]
2011-07-13 12:32 ` Luiz Capitulino
2011-07-13 13:45 ` Gerd Hoffmann
2011-07-13 14:10 ` Alon Levy
2011-07-13 14:25 ` Gerd Hoffmann
2011-07-13 10:50 ` Daniel P. Berrange
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl-render: split out qxl_render_update_dirty_rectangles Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl-render: qxl_render_update: nop if \!ssd.running Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_area_complete Alon Levy
2011-07-13 7:51 ` Gerd Hoffmann
2011-07-13 9:30 ` Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort) Alon Levy
2011-07-13 7:54 ` Gerd Hoffmann
2011-07-13 9:17 ` Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support Alon Levy
2011-07-13 6:43 ` [Qemu-devel] [PATCHv3] async + suspend reworked Gerd Hoffmann
2011-07-13 8:51 ` Alon Levy
2011-07-13 10:45 ` Gerd Hoffmann
2011-07-13 11:24 ` Alon Levy
2011-07-13 7:11 ` Gerd Hoffmann
2011-07-13 9:05 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110713101504.66fc9a16@doriath \
--to=lcapitulino@redhat.com \
--cc=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.