From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: util-linux-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:46650 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945Ab1GMMMj (ORCPT ); Wed, 13 Jul 2011 08:12:39 -0400 Date: Wed, 13 Jul 2011 14:12:32 +0200 From: Karel Zak To: kerolasa@gmail.com Cc: dave@gnu.org, util-linux@vger.kernel.org Subject: Re: [PATCH] minix: v3 super-block does not have s_state field Message-ID: <20110713121232.GC3486@nb.net.home> References: <1310485846-3685-1-git-send-email-kerolasa@iki.fi> <1310529931.4444.7.camel@offbook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: util-linux-owner@vger.kernel.org List-ID: On Wed, Jul 13, 2011 at 01:33:03PM +0200, Sami Kerola wrote: > On Wed, Jul 13, 2011 at 06:05, Davidlohr Bueso wrote: > > I don't think we should always rely on having the kernel headers, that's > > why the fallback is provided. > [snip] > > I think with this patch we address the issue without removing our > > fallback. > > Hi Dave et.al. > > The preprocessor directive bellow is problematic. I don't see where, > or how, it might get satisfied so I am afraid the 'fall back' is > always in use regardless whether an user has kernel headers or not. > > #ifdef KERNEL_INCLUDES_ARE_CLEAN > > To fix that I modified the patch to use autoconf to check whether each > necessary header is present, and use them if possible. Notice that > Dave that I wrote your name to Reviewed-by patch line so it would be > nice to hear that you're OK with the change. See the attachment, or > pull from my repository. This is wrong way... the kernel types (e.g. u32, s64) are *unexpected* in util-linux. The new code should not use this junk. We have and . The mkfs.minix should not depend on kernel headers. It's normal that we use our own (on kernel independent) copy of FS superbloks. See libblkid code. There is libblkid/src/superblocks/minix.c where are minix superblocks, it would be probably better to move the superblocks to iniclude/minix.h and use it everywhere. Karel -- Karel Zak http://karelzak.blogspot.com