From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qgz0E-0005aI-8m for qemu-devel@nongnu.org; Wed, 13 Jul 2011 08:57:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qgz0C-0006Ig-Hi for qemu-devel@nongnu.org; Wed, 13 Jul 2011 08:57:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qgz0C-0006Ia-01 for qemu-devel@nongnu.org; Wed, 13 Jul 2011 08:57:20 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6DCvJ5h000633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Jul 2011 08:57:19 -0400 Date: Wed, 13 Jul 2011 15:56:55 +0300 From: Alon Levy Message-ID: <20110713125655.GM28430@bow.tlv.redhat.com> References: <1310478932-25370-1-git-send-email-alevy@redhat.com> <1310478932-25370-14-git-send-email-alevy@redhat.com> <4E1D44DB.5090803@redhat.com> <20110713092909.GF28430@bow.tlv.redhat.com> <4E1D766C.1090308@redhat.com> <20110713112916.GL28430@bow.tlv.redhat.com> <20110713093326.272983a1@doriath> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110713093326.272983a1@doriath> Subject: Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Wed, Jul 13, 2011 at 09:33:26AM -0300, Luiz Capitulino wrote: > On Wed, 13 Jul 2011 14:29:16 +0300 > Alon Levy wrote: > > > On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > > > On 07/13/11 11:29, Alon Levy wrote: > > > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > > > >>On 07/12/11 15:55, Alon Levy wrote: > > > >>>Later the save will happen asynchronously on surface_updated callback. > > > >> > > > >>Hmm. I can see why you are doing that. It makes the file being > > > >>written *after* the monitor command finishes though, which I think > > > >>we should avoid. > > > > > > > >I think the simplest thing would be to add a specific cond for this - ppm_save_filename_cond. ok? > > > > > > Not sure. Luiz, do we have async monitor commands meanwhile? > > > > > > Background: screendump for qxl vga can take a while as the > > > spice-server might have to render everything first ... > > > > I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's becoming pretty > > ugly. > > IIRC, that interface doesn't work as expected and is going to be replaced > by the QAPI's one. In what way is in wrong? it seems to work fine here - monitor is blocked until I call the callback, after which it returns. Didn't test the qmp part though. > > > Also I guess what Daniel described is possible, but it changes the usage of screendump > > even more. Is turning do_screen_dump to async viable? I think I'll work on it. > > > > > > > > cheers, > > > Gerd > > > > > >