From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgzHX-0001ZO-Ea for qemu-devel@nongnu.org; Wed, 13 Jul 2011 09:15:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgzHR-0000OW-8k for qemu-devel@nongnu.org; Wed, 13 Jul 2011 09:15:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgzHQ-0000O6-Rb for qemu-devel@nongnu.org; Wed, 13 Jul 2011 09:15:09 -0400 Date: Wed, 13 Jul 2011 14:14:58 +0100 From: "Daniel P. Berrange" Message-ID: <20110713131458.GE22414@redhat.com> References: <1309872100-27912-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1309872100-27912-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6 Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@linux.vnet.ibm.com, lcapitulino@redhat.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com On Tue, Jul 05, 2011 at 08:21:36AM -0500, Michael Roth wrote: > BUILD/USAGE > > build: > ./configure --target-list=x86_64-softmmu > make > make qemu-ga #should be built on|for target guest > > start guest: > qemu \ > -drive file=/home/mdroth/vm/rhel6_64_base.raw,snapshot=off,if=virtio \ > -net nic,model=virtio,macaddr=52:54:00:12:34:00 \ > -net tap,script=/etc/qemu-ifup \ > -vnc :1 -m 1024 --enable-kvm \ > -chardev socket,path=/tmp/qga.sock,server,nowait,id=qga \ > -device virtio-serial \ > -device virtserialport,chardev=qga,name=qga" > > use guest agent: > ./qemu-ga -h > ./qemu-ga -c virtio-serial -p /dev/virtio-ports/qga Have we documented any naming convention for virtio serial ports yet ? For both Matahari, and libguestfs we've followed the reverse domain name style naming adopted by things like DBus and AMQP, or language package namespaces. eg org.libguestfs.channel.0 org.apache.qpid.matahari.0 The '.0' is just in case we find we need to add further channels for each agent later with different usage. I think this would be a good general naming convention to recommend to app developers in order to avoid naming clashes, and thus think that the QEMU guest agent should use a channel name prefixed with 'org.qemu.' eg perhaps ... -device virtserialport,chardev=qga,name=org.qemu.guestagent.0" ... ./qemu-ga -c virtio-serial -p /dev/virtio-ports/org.qemu.guestagent.0 Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|