From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qh2B4-000784-Rc
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 12:20:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qh2B3-0005Nj-4V
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 12:20:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32868)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qh2B2-0005Nd-I7
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 12:20:44 -0400
Date: Wed, 13 Jul 2011 13:20:33 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110713132033.3480f29b@doriath>
In-Reply-To: <alpine.LNX.2.00.1107131836510.4791@linmac>
References: <1310567013-11058-1-git-send-email-lcapitulino@redhat.com>
	<1310567013-11058-2-git-send-email-lcapitulino@redhat.com>
	<alpine.LNX.2.00.1107131836510.4791@linmac>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Wed, 13 Jul 2011 18:37:31 +0400 (MSD)
malc <av1474@comtv.ru> wrote:

> On Wed, 13 Jul 2011, Luiz Capitulino wrote:
> 
> > From: Luiz Capitulino <lcapitulino@gmail.com>
> > 
> > This moves compiler related macros from qemu-common.h to compiler.h.
> > 
> > The reason for this change is that there are simple header files that
> > depend only on the compiler macros, so including qemu-common.h is overkill.
> > 
> > Besides, qemu-common.h is bloated and will benefit from some splitting.
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@gmail.com>
> > ---
> >  compiler.h    |   31 +++++++++++++++++++++++++++++++
> >  qemu-common.h |   25 +------------------------
> >  2 files changed, 32 insertions(+), 24 deletions(-)
> >  create mode 100644 compiler.h
> > 
> > diff --git a/compiler.h b/compiler.h
> > new file mode 100644
> > index 0000000..2dfc2c6
> > --- /dev/null
> > +++ b/compiler.h
> > @@ -0,0 +1,31 @@
> > +#ifndef COMPILER_H
> > +#define COMPILER_H
> > +
> > +#include "config-host.h"
> > +
> > +#define QEMU_NORETURN __attribute__ ((__noreturn__))
> > +#ifdef CONFIG_GCC_ATTRIBUTE_WARN_UNUSED_RESULT
> > +#define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
> > +#else
> > +#define QEMU_WARN_UNUSED_RESULT
> > +#endif
> > +
> > +#define QEMU_BUILD_BUG_ON(x) typedef char __build_bug_on__##__LINE__[(x)?-1:1];
> 
> Identifiers starting with double underscore are reserved for all uses,
> so, please, use something else.

I'll fix it as an additional patch:

diff --git a/compiler.h b/compiler.h
index 2dfc2c6..54720bf 100644
--- a/compiler.h
+++ b/compiler.h
@@ -10,7 +10,8 @@
 #define QEMU_WARN_UNUSED_RESULT
 #endif
 
-#define QEMU_BUILD_BUG_ON(x) typedef char __build_bug_on__##__LINE__[(x)?-1:1];
+#define QEMU_BUILD_BUG_ON(x) \
+    typedef char qemu_build_bug_on__##__LINE__[(x)?-1:1];
 
 #if defined __GNUC__
 # if (__GNUC__ < 4) || \