From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh2HT-0000sJ-0j for qemu-devel@nongnu.org; Wed, 13 Jul 2011 12:27:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qh2HN-0006fd-Sf for qemu-devel@nongnu.org; Wed, 13 Jul 2011 12:27:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh2HN-0006fP-Ec for qemu-devel@nongnu.org; Wed, 13 Jul 2011 12:27:17 -0400 Date: Wed, 13 Jul 2011 13:27:06 -0300 From: Luiz Capitulino Message-ID: <20110713132706.3ecf8a09@doriath> In-Reply-To: References: <1310567013-11058-1-git-send-email-lcapitulino@redhat.com> <1310567013-11058-2-git-send-email-lcapitulino@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Wed, 13 Jul 2011 16:04:52 +0100 Peter Maydell wrote: > On 13 July 2011 15:23, Luiz Capitulino wrote: > > diff --git a/compiler.h b/compiler.h > > new file mode 100644 > > index 0000000..2dfc2c6 > > --- /dev/null > > +++ b/compiler.h > > @@ -0,0 +1,31 @@ > > +#ifndef COMPILER_H > > +#define COMPILER_H > > If we don't have a rule that says that all new source files should have > a standard-ish format copyright notice and license statement, I think > we ought to. Make sense, but this content comes from qemu-common.h which doesn't have that information. I can't choose for the authors. Malc is one of them, and he asked me to remove the license text altogether (which makes this public domain?) > > (This came up last in the discussion over importing Linux kernel > headers into the qemu tree. Having every file's status be clear and > clearly stated makes life easier for people who have to check these > things before redistributing...) > > -- PMM >