From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, lrg@ti.com, khilman@ti.com
Subject: Re: [PATCHv2 2/5] regulator: omap smps regulator driver
Date: Wed, 13 Jul 2011 23:40:22 +0900 [thread overview]
Message-ID: <20110713144019.GA7861@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1310565638-13140-3-git-send-email-t-kristo@ti.com>
On Wed, Jul 13, 2011 at 05:00:35PM +0300, Tero Kristo wrote:
> +config REGULATOR_OMAP_SMPS
> + tristate "TI OMAP SMPS Power Regulators"
> + depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM && TWL4030_CORE
What is the dependency on the TWL4030? I see no references to it in the
code...
> + for (i = 0; i < pdata->num_regulators; i++) {
> + initdata = pdata->regulators[i];
> +
I do strongly prefer the idiom of just registering all the regulators
even if they're read only.
> + c = &initdata->constraints;
> + c->valid_modes_mask &= REGULATOR_MODE_NORMAL;
> + c->valid_ops_mask &= REGULATOR_CHANGE_VOLTAGE;
> + c->always_on = true;
No, this is bad. We *always* pay attention to the constraints the user
set even if they're nuts or won't work, the machine driver has the final
say on what is or isn't allowed on a given board. The mode setting is
especially suspect as there's no mode support in the driver.
next prev parent reply other threads:[~2011-07-13 14:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 14:00 [PATCHv2 0/5] OMAP SMPS regulator driver Tero Kristo
2011-07-13 14:00 ` [PATCHv2 1/5] OMAP: move voltage.h and vp.h under platform include directory Tero Kristo
2011-07-13 14:00 ` [PATCHv2 2/5] regulator: omap smps regulator driver Tero Kristo
2011-07-13 14:40 ` Mark Brown [this message]
2011-07-13 15:53 ` Tero Kristo
2011-07-13 22:55 ` Mark Brown
2011-07-14 7:51 ` Tero Kristo
2011-07-14 6:29 ` Todd Poynor
2011-07-14 7:23 ` Tero Kristo
2011-07-13 14:00 ` [PATCHv2 3/5] omap3: beagle: instantiate smps regulators Tero Kristo
2011-07-13 14:00 ` [PATCHv2 4/5] TEMP: OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-07-13 17:49 ` Premi, Sanjeev
2011-07-14 7:10 ` Tero Kristo
2011-07-14 8:46 ` Premi, Sanjeev
2011-07-13 14:00 ` [PATCHv2 5/5] omap: voltage: changed parameter of omap_voltage_lookup to const Tero Kristo
2011-07-13 19:00 ` [PATCHv2 0/5] OMAP SMPS regulator driver Kevin Hilman
2011-07-13 23:22 ` Mark Brown
2011-07-13 23:51 ` Kevin Hilman
2011-07-14 0:22 ` Kevin Hilman
2011-07-14 7:24 ` Tero Kristo
2011-07-18 8:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110713144019.GA7861@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.