From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109Ab1GNEqx (ORCPT ); Thu, 14 Jul 2011 00:46:53 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:54531 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880Ab1GNEqw (ORCPT ); Thu, 14 Jul 2011 00:46:52 -0400 Date: Thu, 14 Jul 2011 00:46:43 -0400 From: Christoph Hellwig To: KAMEZAWA Hiroyuki Cc: Mel Gorman , Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-ID: <20110714044643.GA3203@infradead.org> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > + /* > > + * Only kswapd can writeback filesystem pages to > > + * avoid risk of stack overflow > > + */ > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > + goto keep_locked; > > + } > > + > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). XFS and btrfs already disable writeback from memcg context, as does ext4 for the typical non-overwrite workloads, and none has fallen apart. In fact there's no way we can enable them as the memcg calling contexts tend to have massive stack usage. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p6E4kwxo115149 for ; Wed, 13 Jul 2011 23:46:58 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5BCD2BAC6B6 for ; Wed, 13 Jul 2011 21:46:53 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id 8TfPIaDGa8QRk13B for ; Wed, 13 Jul 2011 21:46:53 -0700 (PDT) Date: Thu, 14 Jul 2011 00:46:43 -0400 From: Christoph Hellwig Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-ID: <20110714044643.GA3203@infradead.org> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: KAMEZAWA Hiroyuki Cc: Rik van Riel , Jan Kara , LKML , XFS , Christoph Hellwig , Linux-MM , Mel Gorman , Wu Fengguang , Johannes Weiner , Minchan Kim On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > + /* > > + * Only kswapd can writeback filesystem pages to > > + * avoid risk of stack overflow > > + */ > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > + goto keep_locked; > > + } > > + > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). XFS and btrfs already disable writeback from memcg context, as does ext4 for the typical non-overwrite workloads, and none has fallen apart. In fact there's no way we can enable them as the memcg calling contexts tend to have massive stack usage. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 41F566B004A for ; Thu, 14 Jul 2011 00:46:53 -0400 (EDT) Date: Thu, 14 Jul 2011 00:46:43 -0400 From: Christoph Hellwig Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-ID: <20110714044643.GA3203@infradead.org> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: Mel Gorman , Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > + /* > > + * Only kswapd can writeback filesystem pages to > > + * avoid risk of stack overflow > > + */ > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > + goto keep_locked; > > + } > > + > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). XFS and btrfs already disable writeback from memcg context, as does ext4 for the typical non-overwrite workloads, and none has fallen apart. In fact there's no way we can enable them as the memcg calling contexts tend to have massive stack usage. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org