From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753079Ab1GNGTT (ORCPT ); Thu, 14 Jul 2011 02:19:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56613 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102Ab1GNGTT (ORCPT ); Thu, 14 Jul 2011 02:19:19 -0400 Date: Thu, 14 Jul 2011 07:19:15 +0100 From: Mel Gorman To: KAMEZAWA Hiroyuki Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-ID: <20110714061915.GN7529@suse.de> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > @@ -825,6 +825,15 @@ static unsigned long shrink_page_list(struct list_head *page_list, > > if (PageDirty(page)) { > > nr_dirty++; > > > > + /* > > + * Only kswapd can writeback filesystem pages to > > + * avoid risk of stack overflow > > + */ > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > + goto keep_locked; > > + } > > + > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). > > Could you make this > > if (scanning_global_lru(sc) && page_is_file_cache(page) && !current_is_kswapd()) > ... > I can, but as Christoph points out, the request is already being ignored so how will it help? -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p6E6JJUt120520 for ; Thu, 14 Jul 2011 01:19:20 -0500 Received: from mx2.suse.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4C1F4EBD65F for ; Wed, 13 Jul 2011 23:19:18 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id swuLhqW3mHSHWGgD for ; Wed, 13 Jul 2011 23:19:18 -0700 (PDT) Date: Thu, 14 Jul 2011 07:19:15 +0100 From: Mel Gorman Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-ID: <20110714061915.GN7529@suse.de> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: KAMEZAWA Hiroyuki Cc: Rik van Riel , Jan Kara , LKML , XFS , Christoph Hellwig , Linux-MM , Minchan Kim , Wu Fengguang , Johannes Weiner On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > @@ -825,6 +825,15 @@ static unsigned long shrink_page_list(struct list_head *page_list, > > if (PageDirty(page)) { > > nr_dirty++; > > > > + /* > > + * Only kswapd can writeback filesystem pages to > > + * avoid risk of stack overflow > > + */ > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > + goto keep_locked; > > + } > > + > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). > > Could you make this > > if (scanning_global_lru(sc) && page_is_file_cache(page) && !current_is_kswapd()) > ... > I can, but as Christoph points out, the request is already being ignored so how will it help? -- Mel Gorman SUSE Labs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id EBEFD6B00E7 for ; Thu, 14 Jul 2011 02:19:20 -0400 (EDT) Date: Thu, 14 Jul 2011 07:19:15 +0100 From: Mel Gorman Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-ID: <20110714061915.GN7529@suse.de> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > @@ -825,6 +825,15 @@ static unsigned long shrink_page_list(struct list_head *page_list, > > if (PageDirty(page)) { > > nr_dirty++; > > > > + /* > > + * Only kswapd can writeback filesystem pages to > > + * avoid risk of stack overflow > > + */ > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > + goto keep_locked; > > + } > > + > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). > > Could you make this > > if (scanning_global_lru(sc) && page_is_file_cache(page) && !current_is_kswapd()) > ... > I can, but as Christoph points out, the request is already being ignored so how will it help? -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org