From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhHdn-0006ag-Ih for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:51:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QhHdl-0003QG-Qp for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:51:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhHdl-0003Q2-6t for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:51:25 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6E8pNvw016399 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Jul 2011 04:51:23 -0400 Date: Thu, 14 Jul 2011 11:51:01 +0300 From: Alon Levy Message-ID: <20110714085101.GD23682@bow.tlv.redhat.com> References: <1310568597-24181-1-git-send-email-alevy@redhat.com> <1310568597-24181-8-git-send-email-alevy@redhat.com> <4E1EAC3E.6070903@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E1EAC3E.6070903@redhat.com> Subject: Re: [Qemu-devel] [PATCHv4 07/11] qxl: make qxl_guest_bug take variable arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: yhalperi@redhat.com, qemu-devel@nongnu.org On Thu, Jul 14, 2011 at 10:43:42AM +0200, Gerd Hoffmann wrote: > Hi, > > >- qxl_guest_bug(d, "QXL_IO_MEMSLOT_ADD: val out of range"); > >+ qxl_guest_bug(d, "QXL_IO_MEMSLOT_ADD: val out of range\n"); > > Why this change? I'd prefer qxl_guest_bug adding the newline. Just to save a fprintf. I can put it back. > > cheers, > Gerd >