All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Francesco RUNDO <francesco.rundo@st.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] kill05: Added proper return code (TPASS) if testcase exit without errors.
Date: Thu, 14 Jul 2011 12:32:04 +0200	[thread overview]
Message-ID: <20110714103204.GA2018@saboteur.suse.cz> (raw)
In-Reply-To: <000c01cc41f3$bf4c0370$3de40a50$@rundo@st.com>

Hi!
> Thanks for your comment.
> 
> Anyway, I know LTP initalizes the return value to 0 (TPASS) but the problem
> is that this return code was "not reported" in the LTP log (in the same way
> used by other testcases) and, moreover, the "kill05" output message was
> misleading as it reported only the message " "kill failed with EPERM"
> without any further message which explained that EPERM was the expected test
> result and then the test worked fine.
> 
> Without above info, the result of the test was not very clear taking into
> account the output message ("kill failed with EPERM") which didn't include
> any further info about:
> 
> 1. LTP exit code (TPASS/TFAIL/TINFO/TBROK...); 
> 2. "obtained result" against "expected ones";

Okay, so the commit description was a bit misleading as return value is
integer nuber returned after process has ceased to exist. I would rather
change it to "kill05 didn't print ...".

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on "Lean Startup 
Secrets Revealed." This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2011-07-14 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 14:27 [LTP] [PATCH] kill05: Added proper return code (TPASS) if testcase exit without errors Francesco RUNDO
2011-07-13 15:33 ` Cyril Hrubis
     [not found]   ` <000c01cc41f3$bf4c0370$3de40a50$@rundo@st.com>
2011-07-14 10:32     ` Cyril Hrubis [this message]
     [not found]       ` <000d01cc421a$607dc5a0$217950e0$@rundo@st.com>
2011-07-14 11:56         ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110714103204.GA2018@saboteur.suse.cz \
    --to=chrubis@suse.cz \
    --cc=francesco.rundo@st.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.