From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800Ab1GNExz (ORCPT ); Thu, 14 Jul 2011 00:53:55 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:35606 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683Ab1GNExy (ORCPT ); Thu, 14 Jul 2011 00:53:54 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Thu, 14 Jul 2011 13:46:34 +0900 From: KAMEZAWA Hiroyuki To: Christoph Hellwig Cc: Mel Gorman , Linux-MM , LKML , XFS , Dave Chinner , Johannes Weiner , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-Id: <20110714134634.4a7a15c8.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20110714044643.GA3203@infradead.org> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> <20110714044643.GA3203@infradead.org> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.1 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jul 2011 00:46:43 -0400 Christoph Hellwig wrote: > On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > > + /* > > > + * Only kswapd can writeback filesystem pages to > > > + * avoid risk of stack overflow > > > + */ > > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > > + goto keep_locked; > > > + } > > > + > > > > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). > > XFS and btrfs already disable writeback from memcg context, as does ext4 > for the typical non-overwrite workloads, and none has fallen apart. > > In fact there's no way we can enable them as the memcg calling contexts > tend to have massive stack usage. > Hmm, XFS/btrfs adds pages to radix-tree in deep stack ? Thanks, -Kame From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p6E4rtTF115484 for ; Wed, 13 Jul 2011 23:53:55 -0500 Received: from fgwmail6.fujitsu.co.jp (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 99D1FEA6EA5 for ; Wed, 13 Jul 2011 21:53:54 -0700 (PDT) Received: from fgwmail6.fujitsu.co.jp (fgwmail6.fujitsu.co.jp [192.51.44.36]) by cuda.sgi.com with ESMTP id A54jPYZ7hfey5qJd for ; Wed, 13 Jul 2011 21:53:54 -0700 (PDT) Received: from m4.gw.fujitsu.co.jp (unknown [10.0.50.74]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id A90D33EE0BB for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 8EDE845DE67 for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 6D36845DE6A for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 59D761DB8040 for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.240.81.147]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 198D51DB8037 for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Date: Thu, 14 Jul 2011 13:46:34 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-Id: <20110714134634.4a7a15c8.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20110714044643.GA3203@infradead.org> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> <20110714044643.GA3203@infradead.org> Mime-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: Rik van Riel , Jan Kara , LKML , XFS , Linux-MM , Mel Gorman , Wu Fengguang , Johannes Weiner , Minchan Kim On Thu, 14 Jul 2011 00:46:43 -0400 Christoph Hellwig wrote: > On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > > + /* > > > + * Only kswapd can writeback filesystem pages to > > > + * avoid risk of stack overflow > > > + */ > > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > > + goto keep_locked; > > > + } > > > + > > > > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). > > XFS and btrfs already disable writeback from memcg context, as does ext4 > for the typical non-overwrite workloads, and none has fallen apart. > > In fact there's no way we can enable them as the memcg calling contexts > tend to have massive stack usage. > Hmm, XFS/btrfs adds pages to radix-tree in deep stack ? Thanks, -Kame _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id A281C6B0083 for ; Thu, 14 Jul 2011 00:53:55 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id B9B183EE0C2 for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 9D3EC45DEB8 for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 83C9D45DEB5 for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 71DB31DB8040 for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.240.81.147]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1B0911DB803F for ; Thu, 14 Jul 2011 13:53:52 +0900 (JST) Date: Thu, 14 Jul 2011 13:46:34 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/5] mm: vmscan: Do not writeback filesystem pages in direct reclaim Message-Id: <20110714134634.4a7a15c8.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20110714044643.GA3203@infradead.org> References: <1310567487-15367-1-git-send-email-mgorman@suse.de> <1310567487-15367-2-git-send-email-mgorman@suse.de> <20110714103801.83e10fdb.kamezawa.hiroyu@jp.fujitsu.com> <20110714044643.GA3203@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: Mel Gorman , Linux-MM , LKML , XFS , Dave Chinner , Johannes Weiner , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim On Thu, 14 Jul 2011 00:46:43 -0400 Christoph Hellwig wrote: > On Thu, Jul 14, 2011 at 10:38:01AM +0900, KAMEZAWA Hiroyuki wrote: > > > + /* > > > + * Only kswapd can writeback filesystem pages to > > > + * avoid risk of stack overflow > > > + */ > > > + if (page_is_file_cache(page) && !current_is_kswapd()) { > > > + inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > > + goto keep_locked; > > > + } > > > + > > > > > > This will cause tons of memcg OOM kill because we have no help of kswapd (now). > > XFS and btrfs already disable writeback from memcg context, as does ext4 > for the typical non-overwrite workloads, and none has fallen apart. > > In fact there's no way we can enable them as the memcg calling contexts > tend to have massive stack usage. > Hmm, XFS/btrfs adds pages to radix-tree in deep stack ? Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org