From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Pekka Enberg <penberg@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org
Subject: Re: possible recursive locking detected cache_alloc_refill() + cache_flusharray()
Date: Sat, 23 Jul 2011 13:22:07 +0200 [thread overview]
Message-ID: <20110723112207.GA2355@breakpoint.cc> (raw)
In-Reply-To: <1311341165.27400.58.camel@twins>
* Thus spake Peter Zijlstra (peterz@infradead.org):
> Thanks!
You're welcome.
> > +static void slab_each_set_lock_classes(struct kmem_cache *cachep)
> > +{
> > + int node;
> > +
> > + for_each_online_node(node) {
> > + slab_set_lock_classes(cachep, &debugobj_l3_key,
> > + &debugobj_alc_key, node);
> > + }
> > +}
>
> Hmm, O(nr_nodes^2), sounds about right for alien crap, right?
A little less if not all nodes are online :) However it is the same kind of
init used earlier by setup_cpu_cache().
I tried to pull lockclass into cachep but lockdep didn't like this.
> Still needs some hotplug love though, maybe something like the below...
> Sebastian, would you be willing to give the thing another spin to see if
> I didnt (again) break anything silly?
Looks good, compiles and seems to work :)
Sebastian
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-23 11:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 21:18 possible recursive locking detected cache_alloc_refill() + cache_flusharray() Sebastian Siewior
2011-07-17 21:34 ` Thomas Gleixner
2011-07-20 13:21 ` Pekka Enberg
2011-07-20 13:30 ` Peter Zijlstra
2011-07-20 13:52 ` Pekka Enberg
2011-07-20 14:00 ` Christoph Lameter
2011-07-20 15:44 ` Peter Zijlstra
2011-07-21 7:14 ` Sebastian Siewior
2011-07-22 8:17 ` Pekka Enberg
2011-07-22 13:26 ` Peter Zijlstra
2011-07-23 11:22 ` Sebastian Andrzej Siewior [this message]
2011-08-04 8:35 ` [tip:core/urgent] slab, lockdep: Annotate slab -> rcu -> debug_object -> slab tip-bot for Peter Zijlstra
2011-07-28 10:46 ` possible recursive locking detected cache_alloc_refill() + cache_flusharray() Pekka Enberg
2011-07-28 10:56 ` Sebastian Andrzej Siewior
2011-07-28 10:56 ` Peter Zijlstra
2011-07-28 10:55 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110723112207.GA2355@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=cl@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.