From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] vfs: move ACL cache lookup into generic code
Date: Sat, 23 Jul 2011 16:32:00 +0100
Message-ID: <20110723153200.GF24703@ZenIV.linux.org.uk>
References: <alpine.LFD.2.02.1107221023170.29055@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107221038090.29055@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107221932120.27112@i5.linux-foundation.org>
 <20110723032944.GA24703@ZenIV.linux.org.uk>
 <20110723074722.GD24703@ZenIV.linux.org.uk>
 <20110723145037.GA10213@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:56340 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752516Ab1GWPcB (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 23 Jul 2011 11:32:01 -0400
Content-Disposition: inline
In-Reply-To: <20110723145037.GA10213@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Jul 23, 2011 at 04:50:37PM +0200, Christoph Hellwig wrote:
> On Sat, Jul 23, 2011 at 08:47:22AM +0100, Al Viro wrote:
> > Anyway, that'll have to wait for tomorrow; I'm going down right now.  This
> > stuff (plus Tim's "mount lock scalability for internal mounts" patch) is
> > in #untested in usual place.  Comments/testing/etc. are welcome...
> 
> Can't be just pass &inode->i_mode to posix_acl_create for those filesystems
> that simply write directly into i_mode, instead of keeping it in a local
> variable?

umode_t vs. mode_t...
 
> Also the posix_acl_create should be after the function body, not a lot
> before it.

???
Oh, you mean the export for it?  Done (and pushed)