From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337Ab1GYJ2i (ORCPT ); Mon, 25 Jul 2011 05:28:38 -0400 Date: Mon, 25 Jul 2011 11:29:30 +0200 From: Stanislaw Gruszka To: Rajkumar Manoharan Cc: linux-wireless , ath9k-devel@venema.h4ckr.net, camilo@mesias.co.uk, Jonathan Nieder , Tony Houghton , Adrian Chadd Subject: Re: [RFC/RFT 6/6] ath9k: always initialize hw registers related to PCIe PM Message-ID: <20110725092929.GB2608@redhat.com> (sfid-20110725_112842_292693_9D8DEC83) References: <1311341512-2882-1-git-send-email-sgruszka@redhat.com> <1311341512-2882-7-git-send-email-sgruszka@redhat.com> <20110723051129.GC828@vmraj-lnx.users.atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110723051129.GC828@vmraj-lnx.users.atheros.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Jul 23, 2011 at 10:41:30AM +0530, Rajkumar Manoharan wrote: > > + /* initalize PCIe PM registers if device introduce itself as PCIe */ > > + if (ah->is_pciexpress) > > + ath9k_hw_ops(ah)->config_pci_powersave(ah, false); > > + > Use ath9k_hw_configpcipowersave wrapper instead. I changed wrapper to check ah->aspm_enabled, so if I would use it here it will not setup registers. I think I should comment that. > And ensure that there is no > sideeffect by changing SERDES config from __ath9k_hw_init to pci_probe. Hmm, not sure if I understand what I have to do :-( We have something like that: ath_pci_probe ath9k_init_device ath9k_init_softc ath9k_hw_init __ath9k_hw_init ath9k_hw_configpcipowersave(); I changed it this way: ath_pci_probe ath9k_init_device ath9k_init_softc ath9k_hw_init __ath9k_hw_init ath9k_init_queues ath9k_init_btcoex some other inits ath9k_hw_configpcipowersave(); Can this cause some side effects? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislaw Gruszka Date: Mon, 25 Jul 2011 11:29:30 +0200 Subject: [ath9k-devel] [RFC/RFT 6/6] ath9k: always initialize hw registers related to PCIe PM In-Reply-To: <20110723051129.GC828@vmraj-lnx.users.atheros.com> References: <1311341512-2882-1-git-send-email-sgruszka@redhat.com> <1311341512-2882-7-git-send-email-sgruszka@redhat.com> <20110723051129.GC828@vmraj-lnx.users.atheros.com> Message-ID: <20110725092929.GB2608@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On Sat, Jul 23, 2011 at 10:41:30AM +0530, Rajkumar Manoharan wrote: > > + /* initalize PCIe PM registers if device introduce itself as PCIe */ > > + if (ah->is_pciexpress) > > + ath9k_hw_ops(ah)->config_pci_powersave(ah, false); > > + > Use ath9k_hw_configpcipowersave wrapper instead. I changed wrapper to check ah->aspm_enabled, so if I would use it here it will not setup registers. I think I should comment that. > And ensure that there is no > sideeffect by changing SERDES config from __ath9k_hw_init to pci_probe. Hmm, not sure if I understand what I have to do :-( We have something like that: ath_pci_probe ath9k_init_device ath9k_init_softc ath9k_hw_init __ath9k_hw_init ath9k_hw_configpcipowersave(); I changed it this way: ath_pci_probe ath9k_init_device ath9k_init_softc ath9k_hw_init __ath9k_hw_init ath9k_init_queues ath9k_init_btcoex some other inits ath9k_hw_configpcipowersave(); Can this cause some side effects?