From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823Ab1GYNUo (ORCPT ); Mon, 25 Jul 2011 09:20:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49572 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139Ab1GYNUn (ORCPT ); Mon, 25 Jul 2011 09:20:43 -0400 Date: Mon, 25 Jul 2011 15:20:40 +0200 From: Michal Marek To: =?iso-8859-1?Q?V=EDctor_M=2E_J=E1quez_L=2E?= Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Jianbin Kang , Sam Ravnborg Subject: Re: [PATCH] kbuild: incremental tags updating with GNU GLOBAL Message-ID: <20110725132040.GE4482@sepie.suse.cz> References: <1310379990-4367-1-git-send-email-vjaquez@igalia.com> <4E1AE9E2.2000603@suse.cz> <20110711131725.GA26907@lit.local.igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20110711131725.GA26907@lit.local.igalia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2011 at 03:17:25PM +0200, Víctor M. Jáquez L. wrote: > On Mon, Jul 11, 2011 at 02:17:38PM +0200, Michal Marek wrote: > > On 11.7.2011 12:26, Víctor Manuel Jáquez Leal wrote: > > >Instead of generating the tag database each time the target is ran, is better > > >just update incrementally the database. It will expend less time. > > > > > >Signed-off-by: Víctor Manuel Jáquez Leal > > >--- > > > scripts/tags.sh | 6 +++++- > > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > > >diff --git a/scripts/tags.sh b/scripts/tags.sh > > >index 75c5d24..6a2fedc 100755 > > >--- a/scripts/tags.sh > > >+++ b/scripts/tags.sh > > >@@ -116,7 +116,11 @@ docscope() > > > > > > dogtags() > > > { > > >- all_sources | gtags -f - > > >+ if global -p; then > > >+ global -u > > >+ else > > >+ all_sources | gtags -f - > > >+ fi > > > > Will this handle new source files properly? > > I ran a quick test and yes, it does. I installed global and tried it myself: 1) The first 'make gtags' run prints a rather confusing message (fixable) $ make gtags GEN gtags global: GTAGS not found. $ 2) A second run indexes the _whole_ tree, including everything under arch/. The point of the tags.sh script is that it indexes only files relevant to the current architecture. If someone wants to index the whole tree, they can run global directly. Michal