From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991Ab1G0H6u (ORCPT ); Wed, 27 Jul 2011 03:58:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52985 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753626Ab1G0H6s (ORCPT ); Wed, 27 Jul 2011 03:58:48 -0400 Date: Wed, 27 Jul 2011 09:58:45 +0200 From: Michal Hocko To: Andrew Morton Cc: Igor Mammedov , KAMEZAWA Hiroyuki , Hiroyuki Kamezawa , linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com, linux-mm@kvack.org, Paul Menage , Li Zefan , containers@lists.linux-foundation.org, Tim Deegan Subject: Re: [PATCH] memcg: do not expose uninitialized mem_cgroup_per_node to world Message-ID: <20110727075845.GA4024@tiehlicka.suse.cz> References: <20110601152039.GG4266@tiehlicka.suse.cz> <4DE66BEB.7040502@redhat.com> <4DE8D50F.1090406@redhat.com> <4DEE26E7.2060201@redhat.com> <20110608123527.479e6991.kamezawa.hiroyu@jp.fujitsu.com> <20110608140951.115ab1dd.akpm@linux-foundation.org> <4DF24D04.1080802@redhat.com> <20110726141754.c69b96c6.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110726141754.c69b96c6.akpm@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 26-07-11 14:17:54, Andrew Morton wrote: > On Fri, 10 Jun 2011 18:57:40 +0200 > Igor Mammedov wrote: > > > On 06/08/2011 11:09 PM, Andrew Morton wrote: > > > The original patch: > > > > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > > @@ -4707,7 +4707,6 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) > > > if (!pn) > > > return 1; > > > > > > - mem->info.nodeinfo[node] = pn; > > > for (zone = 0; zone< MAX_NR_ZONES; zone++) { > > > mz =&pn->zoneinfo[zone]; > > > for_each_lru(l) > > > @@ -4716,6 +4715,7 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) > > > mz->on_tree = false; > > > mz->mem = mem; > > > } > > > + mem->info.nodeinfo[node] = pn; > > > return 0; > > > } > > > > > > looks like a really good idea. But it needs a new changelog and I'd be > > > a bit reluctant to merge it as it appears that the aptch removes our > > > only known way of reproducing a bug. > > > > > > So for now I think I'll queue the patch up unchangelogged so the issue > > > doesn't get forgotten about. > > > > > Problem was in rhel's xen hv. > > It was missing fix for imul emulation. > > Details here > > http://lists.xensource.com/archives/html/xen-devel/2011-06/msg00801.html > > Thanks to Tim Deegan and everyone who was involved in the discussion. > > I really don't want to trawl through a lengthy xen bug report The bug turned out to be Xen specific and this patch just hidden the bug in Xen. > and write your changelog for you. > > We still have no changelog for this patch. Please send one. Appart from a better programming style is there any other reason for taking it? If applied it might hide potential bugs when somebody is touching data too early. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 8D3086B00EE for ; Wed, 27 Jul 2011 03:58:49 -0400 (EDT) Date: Wed, 27 Jul 2011 09:58:45 +0200 From: Michal Hocko Subject: Re: [PATCH] memcg: do not expose uninitialized mem_cgroup_per_node to world Message-ID: <20110727075845.GA4024@tiehlicka.suse.cz> References: <20110601152039.GG4266@tiehlicka.suse.cz> <4DE66BEB.7040502@redhat.com> <4DE8D50F.1090406@redhat.com> <4DEE26E7.2060201@redhat.com> <20110608123527.479e6991.kamezawa.hiroyu@jp.fujitsu.com> <20110608140951.115ab1dd.akpm@linux-foundation.org> <4DF24D04.1080802@redhat.com> <20110726141754.c69b96c6.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110726141754.c69b96c6.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Igor Mammedov , KAMEZAWA Hiroyuki , Hiroyuki Kamezawa , linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com, linux-mm@kvack.org, Paul Menage , Li Zefan , containers@lists.linux-foundation.org, Tim Deegan On Tue 26-07-11 14:17:54, Andrew Morton wrote: > On Fri, 10 Jun 2011 18:57:40 +0200 > Igor Mammedov wrote: > > > On 06/08/2011 11:09 PM, Andrew Morton wrote: > > > The original patch: > > > > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > > @@ -4707,7 +4707,6 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) > > > if (!pn) > > > return 1; > > > > > > - mem->info.nodeinfo[node] = pn; > > > for (zone = 0; zone< MAX_NR_ZONES; zone++) { > > > mz =&pn->zoneinfo[zone]; > > > for_each_lru(l) > > > @@ -4716,6 +4715,7 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) > > > mz->on_tree = false; > > > mz->mem = mem; > > > } > > > + mem->info.nodeinfo[node] = pn; > > > return 0; > > > } > > > > > > looks like a really good idea. But it needs a new changelog and I'd be > > > a bit reluctant to merge it as it appears that the aptch removes our > > > only known way of reproducing a bug. > > > > > > So for now I think I'll queue the patch up unchangelogged so the issue > > > doesn't get forgotten about. > > > > > Problem was in rhel's xen hv. > > It was missing fix for imul emulation. > > Details here > > http://lists.xensource.com/archives/html/xen-devel/2011-06/msg00801.html > > Thanks to Tim Deegan and everyone who was involved in the discussion. > > I really don't want to trawl through a lengthy xen bug report The bug turned out to be Xen specific and this patch just hidden the bug in Xen. > and write your changelog for you. > > We still have no changelog for this patch. Please send one. Appart from a better programming style is there any other reason for taking it? If applied it might hide potential bugs when somebody is touching data too early. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org