From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/3] Return 32/64-bit dir name hash according to usage type Date: Wed, 27 Jul 2011 17:02:44 -0400 Message-ID: <20110727210244.GB9066@infradead.org> References: <20110727110148.204979.49551.stgit@localhost.localdomain> <20110727110249.204979.58769.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yong.fan-KloliPT79xf2eFz/2MeuCQ@public.gmane.org, adilger-KloliPT79xf2eFz/2MeuCQ@public.gmane.org, tytso-3s7WtUTddSA@public.gmane.org To: Bernd Schubert Return-path: Content-Disposition: inline In-Reply-To: <20110727110249.204979.58769.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org Please don't mix fs-specific and generic changes in a single patch. Also adding an O_ constant for a kernel-internal flag is wrong, use the FMODE_ namespace for it. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:34094 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754774Ab1G0VCs (ORCPT ); Wed, 27 Jul 2011 17:02:48 -0400 Date: Wed, 27 Jul 2011 17:02:44 -0400 From: Christoph Hellwig To: Bernd Schubert Cc: linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, yong.fan@whamcloud.com, adilger@whamcloud.com, tytso@mit.edu Subject: Re: [PATCH 1/3] Return 32/64-bit dir name hash according to usage type Message-ID: <20110727210244.GB9066@infradead.org> References: <20110727110148.204979.49551.stgit@localhost.localdomain> <20110727110249.204979.58769.stgit@localhost.localdomain> Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110727110249.204979.58769.stgit@localhost.localdomain> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 Please don't mix fs-specific and generic changes in a single patch. Also adding an O_ constant for a kernel-internal flag is wrong, use the FMODE_ namespace for it.